Bidder Info Endpoint: Base Adapter Only Filter #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Sep 12, 2023
endpoints/info/bidders_test.go
Outdated
| expected: `["a","z"]`, | ||
| }, | ||
| { | ||
| name: "defaultequest-one", |
There was a problem hiding this comment.
Should this and the below be defaultrequest rather than defaultequest?
There was a problem hiding this comment.
Yes. Yes it should. Nice catch. Fixed.
AlexBVolcy
reviewed
Sep 13, 2023
| @@ -94,3 +138,32 @@ func prepareBiddersResponseEnabledOnly(bidders config.BidderInfos, aliases map[s | |||
|
|
|||
| return json.Marshal(bidderNames) | |||
| } | |||
|
|
|||
| func prepareBiddersResponseEnabledOnlyBaseOnly(bidders config.BidderInfos) ([]byte, error) { | |||
There was a problem hiding this comment.
Does this function need the word Only in it twice? Would prepareBiddersResponseEnabledBaseOnly be better? Or is it better to clearly state that we're looking for only endpoint Enabled and only Base adapters?
There was a problem hiding this comment.
I don't think it matters too much. The names are intentional to match up with the EnabledOnly and BaseOnly flags.
AlexBVolcy
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: #3079