Adapter aliases - change coreBidderNames to return aliases

[gargcreation1992]

This PR makes changes to CoreBidderNames function to also return alias bidder names. Once we complete this feature, current alias bidder names from CoreBidderNames function will be removed and we will be relying on newly introduced aliasBidderNames.

[SyntaxNode]

Why is it necessary to separate the concept of "core bidders" from aliases? Today, all aliases are already part of the "core bidders" list, except for those defined in the default request, which will be deprecated when this approach is complete.

[gargcreation1992]

Why is it necessary to separate the concept of "core bidders" from aliases? Today, all aliases are already part of the "core bidders" list, except for those defined in the default request, which will be deprecated when this approach is complete.

The eventual objective of this strategy is to establish alias information exclusively through the bidder-info YAML configuration. At present, the CoreBidderNames function encompasses both the concrete bidder names and their aliases. Upon completion of this approach, we will transition the current aliases to adhere to this new approach. The hardcoded alias bidders sourced from CoreBidderNames will be eliminated, and instead, bidderName will be generated from the YAML, utilising the filename as their corresponding BidderName.
Please let me know if I am missing something here.

[VeronikaSolovei9]

Added comments with the refactoring proposal which I hope will make code a little cleaner, save memory and eliminate unnecessary evaluations. Let me know what do you think.

[VeronikaSolovei9]

Thank you for the changes. Looks good to me.

[hhhjort]

We may want to use package variable here. CoreBidderNames() gets called a lot. This was fine when we were just returning a static value, at worst we were doing an extra reference to get the slice. But now we are executing an append function, which is going to reallocate a new chunk of memory on every call, in addition to copying all the values to this new memory location. We should do this just once, and then always return that combined slice on every call. Probably by modifying SetAliasBidderName() to construct the full slice that this function will return.

[gargcreation1992]

fixed here - ec44c52

[hhhjort]

LGTM