Fix for blocked user sync if activities config is not specified. #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Aug 4, 2023
SyntaxNode
reviewed
Aug 7, 2023
endpoints/cookie_sync_test.go
Outdated
| @@ -1909,27 +1909,32 @@ func TestCookieSyncActivityControlIntegration(t *testing.T) { | |||
| testCases := []struct { | |||
| name string | |||
| bidderName string | |||
| allow bool | |||
| accPrivacy *config.AccountPrivacy | |||
There was a problem hiding this comment.
IMHO acc is not a common abbreviation for account. Please consider calling this accountPrivacy for clarity.
privacy/enforcer.go
Outdated
| plan, planDefined := e.plans[activity] | ||
|
|
||
| if !planDefined { | ||
| return ActivityAbstain | ||
| return true |
There was a problem hiding this comment.
This true value is the same as activityDefaultToDefaultResult. Do you think it might be good to extract that to a constant value? in the future, we may need to replace that constant with a function if some of the activities change to a default of false.
SyntaxNode
approved these changes
Aug 7, 2023
AlexBVolcy
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of we return bool instead of activity result we need to check result is not a Deny.