Optionally inherit parent bidder info for alias adapter #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
onkarvhanumante
commented
Aug 3, 2023
onkarvhanumante
commented
- PR builds changes on top of inherit fields for an alias from parent adapter #3000 PR
- This PR makes changes to check if bidder info param is defined for alias. If not, then inherit information from the parent bidder
Check if bidder info param is defined for alias. If not, then inherit information from the parent bidder
SyntaxNode
reviewed
Aug 7, 2023
config/bidderinfo_test.go
Outdated
| assert.Equal(t, test.expectedBidderInfos, bidderInfos) | ||
| } | ||
|
|
||
| test.assertFunc(bidderInfos, err) |
There was a problem hiding this comment.
If each test has it's own assertion there isn't much value in using a table driven format. If there is no good way to generalize the assertions, please use a series of t.Run calls in this method instead.
There was a problem hiding this comment.
89c5363 make changes to remove assertFunc and use common assertion
# Conflicts: # config/bidderinfo.go # config/bidderinfo_test.go
# Conflicts: # config/bidderinfo.go # config/bidderinfo_test.go
gargcreation1992
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.