Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid SDK Rendering API Extensions #2972

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

SyntaxNode
Copy link
Contributor

For our Prebid SDK friends, per #2908.

prebid.MultiBid = buildRequestExtMultiBid(bidder, requestExtParsed.Prebid.MultiBid, alternateBidderCodes)
prebid.Sdk = requestExtParsed.Prebid.Sdk
prebid.Server = requestExtParsed.Prebid.Server
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized the list and added sdk.

SecondaryCategoryIDs []string `json:"secondaryCatIds,omitempty"`
AdapterCode string `json:"adaptercode,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized the list and added RendererName + RendererVersion.

BidAdjustments *ExtRequestPrebidBidAdjustments `json:"bidadjustments,omitempty"`
// ReturnAllBidStatus if true populates bidresponse.ext.prebid.seatnonbid with all bids which was
// either rejected, nobid, input error
ReturnAllBidStatus bool `json:"returnallbidstatus,omitempty"`
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized, organized the groupings, and added sdk.

Copy link
Contributor

@AlexBVolcy AlexBVolcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing looks good. Do we just want to pass values to adapters, correct? Will new meta fields RendererName and RendererVersion be used in future?

@SyntaxNode
Copy link
Contributor Author

Do we just want to pass values to adapters, correct?

Correct. This information will be made available to adapters to consider in placing their bids. In the future, there might be a filtering module.

Will new meta fields RendererName and RendererVersion be used in future?

Bidders can use these fields immediately to share that information with the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants