New Adapter: liftoff #2968

Vungle-GordonTian · 2023-07-25T13:05:29Z

prebid/prebid.github.io#4757

xiaxiao-vungle · 2023-07-26T06:21:39Z

adapters/liftoff/liftoff.go

+		}
+
+		// Check if imp comes with bid floor amount defined in a foreign currency
+		if imp.BidFloor > 0 && imp.BidFloorCur != "" && strings.ToUpper(imp.BidFloorCur) != "USD" {


make "USD" as a const for multiple place using?

xiaxiao-vungle · 2023-07-26T06:23:02Z

adapters/liftoff/liftoff.go

+			// Convert to US dollars
+			convertedValue, err := requestInfo.ConvertCurrency(imp.BidFloor, imp.BidFloorCur, "USD")
+			if err != nil {
+				return nil, []error{err}


if need to append to errs and return?

xiaxiao-vungle · 2023-07-26T06:24:20Z

adapters/liftoff/liftoff.go

+			continue
+		}
+
+		if len(bidderImpExt.PubAppStoreID) > 0 && len(bidderImpExt.PlacementRefID) > 0 && len(bidderImpExt.BidToken) > 0 {


use bidderImpExt.PubAppStoreID != ""?

xiaxiao-vungle · 2023-07-26T06:28:41Z

adapters/liftoff/liftoff.go

+		Endpoint: config.Endpoint,
+	}
+
+	return bidder, nil


return directly? such as:
return &adapter{
Endpoint: config.Endpoint,
}, nil

PS: looks like the bidderName & server is unused?

Yes, it's unused. But the interface must provide the parameters.

SyntaxNode

Great first pass. Thank you for properly handling all errors.

adapters/liftoff/liftoff.go

SyntaxNode · 2023-08-01T19:13:47Z

adapters/liftoff/liftoff.go

+
+type liftoffImpressionExt struct {
+	*adapters.ExtImpBidder
+	// Ext represents the vungle extension.


What's vungle?

Vungle is our company name before merging with liftoff. In our server code it's a field name which holds our external partners' token and other info.

adapters/liftoff/liftoff.go

SyntaxNode · 2023-08-01T19:16:19Z

adapters/liftoff/liftoff.go

+			continue
+		}
+
+		if bidderImpExt.PubAppStoreID != "" && bidderImpExt.PlacementRefID != "" && bidderImpExt.BidToken != "" {


Can you move these length constraints to the bidder params json file? Then you don't need to worry about error handling here.

@SyntaxNode I tried moving it into yaml with "minLength": 1, but when I run the same UT test, got the different reuslt from before. It produces request for case missing_appid_or_placementid.json. Is it right?

adapters/liftoff/liftoff.go

Vungle-GordonTian · 2023-08-03T05:48:10Z

@SyntaxNode PTAL, I think I've fix your comments.

go.mod

gargcreation1992 · 2023-08-03T12:09:54Z

static/bidder-info/liftoff.yaml

@@ -0,0 +1,10 @@
+endpoint: "https://rtb.ads.vungle.com/bid/t/c770f32"
+maintainer:
+  email: [email protected]


sent email to this email address for verification.

@Vungle-GordonTian email is bounced. Could you please re-check if this email ID is working.

@gargcreation1992 I'm sure this is the valid and correct email address. liftoff.io is blocked only in China, otherwise it should be ok. Can u provide your email info such as country/region, address and send server?

Here is the reply that we have received -

Hello [[email protected]](mailto:[email protected]), We're writing to let you know that the group you tried to contact (platform-ssp) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post: * You might have spelled or formatted the group name incorrectly. * The owner of the group may have removed this group. * You may need to join the group before receiving permission to post. * This group may not be open to posting.

@gargcreation1992 Many thanks for the detailed info. I'll reach out to our IT to find out the root cause.

@gargcreation1992 I've reach out to our IT and they have now adjusted the permissions for [email protected] to accept incoming emails from external senders.

Could you try sending an email again and it should all be good.

sent again. Please reply with received.

done. @gargcreation1992

Sonali-More-Xandr · 2023-08-03T12:25:40Z

openrtb_ext/imp_liftoff.go

+	BidToken       string `json:"bid_token,omitempty"`
+	PubAppStoreID  string `json:"app_store_id,omitempty"`
+	PlacementRefID string `json:"placement_reference_id,omitempty"`


Please remove the omitempty tag as all the parameters are defined as required in the bidder-params/liftoff.json

@Sonali-More-Xandr DONE

gargcreation1992 · 2023-08-10T06:48:22Z

adapters/liftoff/liftoff.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: "Unexpected status code: 400. Bad request from publisher. Run with request.debug = 1 for more info.",
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}


this is correct but you might also wanna use built-in methods -

if adapters.IsResponseStatusCodeNoContent(response) { return nil, nil } if err := adapters.CheckResponseStatusCodeForErrors(response); err != nil { return nil, []error{err} }

gargcreation1992 · 2023-08-10T06:54:38Z

adapters/liftoff/liftoff.go

+		for _, temp := range seatBid.Bid {
+			bid := temp // avoid taking address of a for loop variable


this is correct but you might wanna consider the following code to avoid creating a new temp variable -

for i := range seatBid.Bid { b := &adapters.TypedBid{ Bid: &seatBid.Bid[i], BidType: openrtb_ext.BidTypeVideo, } // more code }

Done optimizing

Vungle-GordonTian · 2023-08-11T01:46:25Z

@gargcreation1992 I'm wondering what's the next move since this PR and user documentation PR are both approved? And I've done local end to end test.

gargcreation1992 · 2023-08-11T04:53:49Z

@gargcreation1992 I'm wondering what's the next move since this PR and user documentation PR are both approved? And I've done local end to end test.

@Vungle-GordonTian thanks for being patient on this one. There are two required approvals before we merge this one in. Someone from the team will be taking a look at this PR soon.

Vungle-GordonTian · 2023-08-16T04:52:18Z

@gargcreation1992 Per as the documentation said, you will verify the adapter works correctly on a technical level during the code review, now since the code has been merged, I want to confirm if the technical level verification(I would reckon that as e2e test, right?) has been done.

gargcreation1992 · 2023-08-16T06:46:58Z

@gargcreation1992 Per as the documentation said, you will verify the adapter works correctly on a technical level during the code review, now since the code has been merged, I want to confirm if the technical level verification(I would reckon that as e2e test, right?) has been done.

Please refer to this part of documentation for e2e test - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#manual-end-to-end-tests

The general guideline is to run prebid-server in your local and test your adapter using a sample request as mentioned in the docs above.

Vungle-GordonTian · 2023-09-01T01:48:29Z

@gargcreation1992 Per as the documentation said, you will verify the adapter works correctly on a technical level during the code review, now since the code has been merged, I want to confirm if the technical level verification(I would reckon that as e2e test, right?) has been done.

Please refer to this part of documentation for e2e test - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#manual-end-to-end-tests

The general guideline is to run prebid-server in your local and test your adapter using a sample request as mentioned in the docs above.

@gargcreation1992 Yeah, I've done the local e2e test already.

Vungle-GordonTian · 2023-10-17T04:27:29Z

@gargcreation1992 Per as the documentation said, you will verify the adapter works correctly on a technical level during the code review, now since the code has been merged, I want to confirm if the technical level verification(I would reckon that as e2e test, right?) has been done.

Please refer to this part of documentation for e2e test - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#manual-end-to-end-tests
The general guideline is to run prebid-server in your local and test your adapter using a sample request as mentioned in the docs above.

@gargcreation1992 Yeah, I've done the local e2e test already.

@gargcreation1992 Hi, I am wondering when will our adapter be on production on Xandr side? Will we be informed of it through the group email?

New Adapter: liftoff

847a79b

Vungle-GordonTian mentioned this pull request Jul 25, 2023

Add new adapter doc for liftoff prebid/prebid.github.io#4757

Merged

9 tasks

gargcreation1992 assigned gargcreation1992 and Sonali-More-Xandr Jul 26, 2023

xiaxiao-vungle reviewed Jul 26, 2023

View reviewed changes

Vungle-GordonTian added 2 commits August 1, 2023 20:59

e2e test fix

a9d73c7

fix ut

da690d5

SyntaxNode reviewed Aug 1, 2023

View reviewed changes

fix comments

0356744

Vungle-GordonTian requested a review from SyntaxNode August 2, 2023 13:32

Sonali-More-Xandr reviewed Aug 3, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

undo go.mod and go.sum

3edf986

gargcreation1992 reviewed Aug 3, 2023

View reviewed changes

Sonali-More-Xandr reviewed Aug 3, 2023

View reviewed changes

Vungle-GordonTian added 4 commits August 4, 2023 09:54

remove omitempty

5ac4b43

remove info

4b5c2c3

fix desc

679eacb

remove gvl id

94db677

Vungle-GordonTian requested review from gargcreation1992 and Sonali-More-Xandr August 9, 2023 05:24

modify bid token place

3058ad5

gargcreation1992 reviewed Aug 10, 2023

View reviewed changes

optimize error handle and for-loop variable

ed16100

Vungle-GordonTian requested a review from gargcreation1992 August 10, 2023 08:00

gargcreation1992 approved these changes Aug 10, 2023

View reviewed changes

Sonali-More-Xandr approved these changes Aug 11, 2023

View reviewed changes

Sonali-More-Xandr merged commit d4016a4 into prebid:master Aug 11, 2023

cross-repo-issue-creation bot mentioned this pull request Aug 11, 2023

Port PR from PBS-Go: New Adapter: liftoff prebid/prebid-server-java#2572

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: liftoff #2968

New Adapter: liftoff #2968

Vungle-GordonTian commented Jul 25, 2023

xiaxiao-vungle Jul 26, 2023

xiaxiao-vungle Jul 26, 2023

xiaxiao-vungle Jul 26, 2023

xiaxiao-vungle Jul 26, 2023

Vungle-GordonTian Jul 27, 2023

SyntaxNode left a comment

SyntaxNode Aug 1, 2023

Vungle-GordonTian Aug 2, 2023 •

edited

Loading

SyntaxNode Aug 1, 2023

Vungle-GordonTian Aug 2, 2023

Vungle-GordonTian Aug 2, 2023 •

edited

Loading

Vungle-GordonTian commented Aug 3, 2023

gargcreation1992 Aug 3, 2023

gargcreation1992 Aug 3, 2023

Vungle-GordonTian Aug 4, 2023 •

edited

Loading

gargcreation1992 Aug 4, 2023

Vungle-GordonTian Aug 4, 2023 •

edited

Loading

Vungle-GordonTian Aug 4, 2023

gargcreation1992 Aug 4, 2023

Vungle-GordonTian Aug 4, 2023

Sonali-More-Xandr Aug 3, 2023

Vungle-GordonTian Aug 4, 2023

gargcreation1992 Aug 10, 2023

gargcreation1992 Aug 10, 2023

Vungle-GordonTian Aug 10, 2023

Vungle-GordonTian commented Aug 11, 2023 •

edited

Loading

gargcreation1992 commented Aug 11, 2023

Vungle-GordonTian commented Aug 16, 2023

gargcreation1992 commented Aug 16, 2023

Vungle-GordonTian commented Sep 1, 2023 •

edited

Loading

Vungle-GordonTian commented Oct 17, 2023

		for _, temp := range seatBid.Bid {
		bid := temp // avoid taking address of a for loop variable

New Adapter: liftoff #2968

New Adapter: liftoff #2968

Conversation

Vungle-GordonTian commented Jul 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SyntaxNode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vungle-GordonTian Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vungle-GordonTian Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Vungle-GordonTian commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vungle-GordonTian Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vungle-GordonTian Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vungle-GordonTian commented Aug 11, 2023 • edited Loading

gargcreation1992 commented Aug 11, 2023

Vungle-GordonTian commented Aug 16, 2023

gargcreation1992 commented Aug 16, 2023

Vungle-GordonTian commented Sep 1, 2023 • edited Loading

Vungle-GordonTian commented Oct 17, 2023

Vungle-GordonTian Aug 2, 2023 •

edited

Loading

Vungle-GordonTian Aug 2, 2023 •

edited

Loading

Vungle-GordonTian Aug 4, 2023 •

edited

Loading

Vungle-GordonTian Aug 4, 2023 •

edited

Loading

Vungle-GordonTian commented Aug 11, 2023 •

edited

Loading

Vungle-GordonTian commented Sep 1, 2023 •

edited

Loading