adapters package fixes reported by go vet #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2023 18:22
# github.com/prebid/prebid-server/adapters/rubicon adapters/rubicon/rubicon_test.go:293:9: GetRate passes lock by value: github.com/prebid/prebid-server/adapters/rubicon.mockCurrencyConversion contains github.com/stretchr/testify/mock.Mock contains sync.Mutex adapters/rubicon/rubicon_test.go:298:9: GetRates passes lock by value: github.com/prebid/prebid-server/adapters/rubicon.mockCurrencyConversion contains github.com/stretchr/testify/mock.Mock contains sync.Mutex
# github.com/prebid/prebid-server/adapters/taboola adapters/taboola/taboola.go:256:13: result of fmt.Errorf call not used
# github.com/prebid/prebid-server/openrtb_ext openrtb_ext/imp_adnuntius.go:6:2: struct field tag `json:noCookies` not compatible with reflect.StructTag.Get: bad syntax for struct tag value
# github.com/prebid/prebid-server/adapters/huaweiads adapters/huaweiads/huaweiads.go:905:14: result of fmt.Errorf call not used
gargcreation1992
previously approved these changes
Jul 20, 2023
SyntaxNode
reviewed
Jul 20, 2023
|
@clho40 PR makes changes in Huaweiads adapter code. Please let us know your thoughts in regards of the proposed changes. Prebid team previously tried to reach out to Huaweiads via email. But mail bounced off |
|
LGTM |
@clho40 also requesting to create separate PR to update Huaweiads working email address |
# Conflicts: # openrtb_ext/imp_adnuntius.go
Sonali-More-Xandr
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #2954 for details.