Add metric for tmax timeout exceed count #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As of now, `bidderRequestStartTime` is part of `ExtraRequestInfo`. The ExtraRequestInfo is further passed as details to Adapter's MakeRequest() implementation. - We don't want to pass bidderRequestStartTime details to `MakeRequest()`. So remove bidderRequestStartTime from ExtraRequestInfo and add it in bidRequestOptions.
metrics/prometheus/prometheus.go
Outdated
| @@ -197,6 +198,10 @@ func NewMetrics(cfg config.PrometheusMetrics, disabledMetrics config.DisabledMet | |||
| "connections_opened", | |||
| "Count of successful connections opened to Prebid Server.") | |||
|
|
|||
| metrics.tmaxTimeout = newCounterWithoutLabels(cfg, reg, | |||
| "tmax_timeout", | |||
| "Count of requests rejected due to timeout exceed.") | |||
There was a problem hiding this comment.
lets add tmax in description. How about Count of requests rejected due to Tmax timeout exceed.
There was a problem hiding this comment.
updated description in 62c4b50
onkarvhanumante
force-pushed
the
tmax/add-bidder-resp-min-check
branch
from
ec51657 to
1b6ebea
Compare
onkarvhanumante
changed the base branch from
tmax/add-bidder-resp-min-check
to
master
|
Hi @Sonali-More-Xandr . This pull request has been unblocked but there are conflicts that must be resolved. |
# Conflicts: # exchange/bidder.go # exchange/exchange.go
onkarvhanumante
force-pushed
the
PBS-1173
branch
from
e44b312 to
43f7d59
Compare
onkarvhanumante
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added Tmax.BidderResponseDurationMin check in auction workflow. As per this change, PBS won't send request to bidder server if remaining duration less than BidderResponseDurationMin. This PR adds a counter metric for such rejected request.