Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: deal tiers no longer ignored due to presence of tid #2829

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix: deal tiers no longer ignored due to presence of tid #2829

merged 1 commit into from
Jun 28, 2023

Conversation

bsardo
Copy link
Collaborator

@bsardo bsardo commented Jun 7, 2023

Fixes #2647

@bsardo bsardo closed this Jun 7, 2023
@bsardo bsardo reopened this Jun 7, 2023
@guscarreon guscarreon self-assigned this Jun 13, 2023
guscarreon
guscarreon reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I see the true branch of the if statement in HoldAuction where we apply this functionality is uncovered by the test framework:
image
Can we add an integration or end-to-end test?

@VeronikaSolovei9
Copy link
Contributor

LGTM, yes, please add test if possible

guscarreon
guscarreon approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo mentioned this pull request Jun 28, 2023
Open
@bsardo bsardo merged commit df83c8f into prebid:master Jun 28, 2023
Peiling-Ding pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jul 6, 2023
@bsardo @Peiling-Ding
Fix: deal tiers no longer ignored due to presence of tid (prebid#2829)
3159ed3
Peiling-Ding pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jul 14, 2023
@bsardo @Peiling-Ding
Fix: deal tiers no longer ignored due to presence of tid (prebid#2829)
46da2b7
Peiling-Ding added a commit to ParticleMedia/prebid-server that referenced this pull request Jul 14, 2023
@Peiling-Ding @bsardo
@ecammit @balintvargha @jpiros @ccorbo @akkapur @gsollazzo @darkstarac @Wazabit @jbartek25 @maxime-dupuis @patrickloughrey @radubarbos @VeronikaSolovei9 @onkarvhanumante @GLStephen @dependabot
Peiling/chore/sync to v0.263.0 (#48)
345168a 
* Fix: deal tiers no longer ignored due to presence of tid (prebid#2829)

* CAPT-787: GPP support for imds bidder. (prebid#2867)

Co-authored-by: Timothy M. Ace <[email protected]>

* Adsinteractive: change usersync endpoint to https (prebid#2861)


Co-authored-by: Balint Vargha <[email protected]>

* consumable adapter: add gpp support (prebid#2883)

* feat: IX Bid Adapter - gpp support for user sync urls (prebid#2873)

Co-authored-by: Chris Corbo <[email protected]>

* fix: update links in readme (prebid#2888)

authored by @akkapur

* New Adapter: AIDEM (prebid#2824)


Co-authored-by: AndreaC <[email protected]>
Co-authored-by: Andrea Tumbarello <[email protected]>
Co-authored-by: darkstar <[email protected]>

* Improve Digital adapter: Set currency in bid response (prebid#2886)

* Sharethrough: Support multiformat bid request impression (prebid#2866)

* Triplelift Bid Adapter: Adding GPP Support (prebid#2887)

* YahooAdvertising rebranding to Yahoo Ads. (prebid#2872)


Co-authored-by: oath-jac <[email protected]>

* IX: MultiImp Implementation (prebid#2779)


Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: Oronno Mamun <[email protected]>

* Exchange unit test fix (prebid#2868)

* Semgrep rules for adapters (prebid#2833)

* IX: Remove glog statement (prebid#2909)

* Activities framework (prebid#2844)

* PWBID: Update Default Endpoint (prebid#2903)

* script to run semgrep tests against adapter PRs (prebid#2907)

authored by @onkarvhanumante

* semgrep rule to detect undesirable package imports in adapter code (prebid#2911)

* update package-import message (prebid#2913)

authored by @onkarvhanumante

* Bump google.golang.org/grpc from 1.46.2 to 1.53.0 (prebid#2905)

---------

Co-authored-by: Brian Sardo <[email protected]>
Co-authored-by: Timothy Ace <[email protected]>
Co-authored-by: Timothy M. Ace <[email protected]>
Co-authored-by: balintvargha <[email protected]>
Co-authored-by: Balint Vargha <[email protected]>
Co-authored-by: Jason Piros <[email protected]>
Co-authored-by: ccorbo <[email protected]>
Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: Ankush <[email protected]>
Co-authored-by: Giovanni Sollazzo <[email protected]>
Co-authored-by: AndreaC <[email protected]>
Co-authored-by: Andrea Tumbarello <[email protected]>
Co-authored-by: darkstar <[email protected]>
Co-authored-by: Jozef Bartek <[email protected]>
Co-authored-by: Max Dupuis <[email protected]>
Co-authored-by: Patrick Loughrey <[email protected]>
Co-authored-by: radubarbos <[email protected]>
Co-authored-by: oath-jac <[email protected]>
Co-authored-by: Oronno Mamun <[email protected]>
Co-authored-by: Veronika Solovei <[email protected]>
Co-authored-by: Onkar Hanumante <[email protected]>
Co-authored-by: Stephen Johnston <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guscarreon guscarreon guscarreon approved these changes

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@guscarreon guscarreon

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unmarshal of imp.ext.{bidder} fails in dealTier flow after addition of tid field in impression
3 participants
@bsardo @VeronikaSolovei9 @guscarreon