Core: Transition PAAPI parameters #3670
Conversation
# Conflicts: # src/main/java/org/prebid/server/handler/SetuidHandler.java
|
|
||
| final boolean shouldDropIgb = StringUtils.isEmpty(igi.getImpid()); | ||
| if (shouldDropIgb) { | ||
| conditionalLogger.warn("ExtIgi with absent impId from bidder: " + bidder, logSamplingRate); |
There was a problem hiding this comment.
I've noticed the requirement to emit warning in debug mode, shouldn't we add the warning messages to the response?
| /** | ||
| * Restores ONLY imps from rejection, rejected bids are preserved for analytics. | ||
| * A bid can be rejected only once. | ||
| */ |
There was a problem hiding this comment.
please keep these comments)
There was a problem hiding this comment.
We don't comment code. Only in super tricky situations, which is not the case.
| .fledgeAuctionConfigs(extractFledge(bidResponse)) | ||
| .errors(bidderErrors) | ||
| .bids(extractBids(bidRequest, bidResponse, errors)) | ||
| .igi(extractIgi(bidResponse)) |
There was a problem hiding this comment.
I'm not sure about other exchanges' cases, but changing the existing contract of the IX bid response for PAAPI will immediately break the current PBS-Index integration. Index does not yet support the community extension for Protected Audience, which defines naming and structure differently from Google's defined format.
I assumed that any new implementation would be done separately to ensure backward compatibility with the current integration (i.e., still supporting the older format).
There was a problem hiding this comment.
Its not breaking change. What I have done:
- I have rewritten all bidders to supply PBS with new PA format.
- Added ability to convert new PA format to old Fledge format.
Index does not need to support new PA extensions right now. You can configure output format (old/new) and by default it will respond with old format. Check this out: prebid/prebid-server#3536 (comment)
🔧 Type of changes
✨ What's the context?
prebid/prebid-server#3536
🔎 New Bid Adapter Checklist
🧪 Test plan
Unit tests + functional tests
🏎 Quality check