Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hcl extension support #232

Merged
merged 1 commit into from
Sep 19, 2021
Merged

add hcl extension support #232

merged 1 commit into from
Sep 19, 2021

Conversation

joshsleeper
Copy link
Contributor

@joshsleeper joshsleeper commented Sep 17, 2021 •
edited
Loading

changes

  • add hcl extension support
  • alphabetize EXTENSIONS keys
    • they were mostly there already, but a few weren't quite right

@asottile
Copy link
Member

yeah some of the extensions in EXTENSIONS are intentionally not alphabetized so they can be grouped near their relevant things (for example the nim sources are near each other and csproj was next to csharp)

@asottile asottile changed the title feat(hcl): add hcl extension support add hcl extension support Sep 19, 2021
@asottile
Copy link
Member

one thought is to whether the existing terraform extensions should also set hcl -- but that can always be a followup

@asottile asottile merged commit a8c362d into pre-commit:master Sep 19, 2021
@joshsleeper joshsleeper deleted the patch-1 branch September 20, 2021 12:08
@joshsleeper
Copy link
Contributor Author

ah, sorry for the sorting noise then haha, thanks for the merge and fixing that for me!
I'd def thought about adding hcl to tf and tfvars, but figured I'd keep this simple and focused in case that was up for debate 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshsleeper @asottile