-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.5 #532
Add python 3.5 #532
Conversation
Also allow failure on Python 3.2 as Coverage 4.0 no longer supports Python 3.2
I'd agree; but then 3.2 would not be tested whatsoever. IMO it either needs to be tested with an earlier version of coverage; or have it not be supported. Also, I haven't checked, but I think some of the dependencies do not actually support Python 3.5. 3.5 is relatively new; I'd give it some time so dependencies can update (or course; if they haven't already/are already compatible) |
I think that the dependencies already support Python 3.5. The Python 3.5 build passes on Travis CI, so this should be a fairly good indication that they do. Python 3.2 support was dropped from Coverage 4.0 as is doesn't support unicode literals (see Pep 414). Python 2.6 and 2.7 support it via I think that support for Python 3.2 can safely be dropped. The big hurdle is getting people from Python 2.7 to 3.X, but once they're on 3.X upgrading to 3.X+1 is a lot easier. I imagine the majority of people using PRAW on Python 3.X are on 3.4 anyway. |
We can go ahead and remove support for python 3.2 as well as 2.6. Below are the data for the number of distinct logged PRAW users by python version between 8/27 and 9/02.
|
They do? Then I have practically no objection to that.
Good to know.
And I agree. I always assumed this to be the case as I've never even heard of people using 3.2 and 2.6 anymore which is why in #530, I made mention that it should either be made supported somehow (in case my assumption was incorrect) or testing be dropped, and according to @bboe 's numbers, they mirrors the assumption I had and it's definitely safe to drop support altogether. |
- nightly | ||
- pypy | ||
- pypy3 | ||
matrix: | ||
allow_failures: | ||
- python: nightly | ||
- python: 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we completely remove 3.2?
@JamieMagee thanks for the PR. Can you please make the modifications as per my comments? Also would you be willing to add a changelog entry indicating the drop of support for the two versions, and the addition of 3.5? You can link directly to this PR to provide "more information". Thanks! |
@bboe Done! |
Thanks! |
Also allow failure on Python 3.2 as Coverage 4.0 no longer supports
Python 3.2