Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.5 #532

Merged
merged 2 commits into from
Sep 22, 2015
Merged

Add python 3.5 #532

merged 2 commits into from
Sep 22, 2015

Conversation

JamieMagee
Copy link
Contributor

Also allow failure on Python 3.2 as Coverage 4.0 no longer supports
Python 3.2

Also allow failure on Python 3.2 as Coverage 4.0 no longer supports
Python 3.2
@13steinj
Copy link
Contributor

I'd agree; but then 3.2 would not be tested whatsoever. IMO it either needs to be tested with an earlier version of coverage; or have it not be supported.

Also, I haven't checked, but I think some of the dependencies do not actually support Python 3.5. 3.5 is relatively new; I'd give it some time so dependencies can update (or course; if they haven't already/are already compatible)

@JamieMagee
Copy link
Contributor Author

I think that the dependencies already support Python 3.5. The Python 3.5 build passes on Travis CI, so this should be a fairly good indication that they do.

Python 3.2 support was dropped from Coverage 4.0 as is doesn't support unicode literals (see Pep 414). Python 2.6 and 2.7 support it via future. I don't think that the .travis.yml can be easily extended to install Coverage 3.7.1.

I think that support for Python 3.2 can safely be dropped. The big hurdle is getting people from Python 2.7 to 3.X, but once they're on 3.X upgrading to 3.X+1 is a lot easier. I imagine the majority of people using PRAW on Python 3.X are on 3.4 anyway.

@bboe
Copy link
Member

bboe commented Sep 21, 2015

We can go ahead and remove support for python 3.2 as well as 2.6. Below are the data for the number of distinct logged PRAW users by python version between 8/27 and 9/02.

   26 ( 0.15%) 2.6.6
   47 ( 0.26%) 2.7.1
 1042 ( 5.85%) 2.7.3
 1513 ( 8.50%) 2.7.4
 1005 ( 5.64%) 2.7.5
 2764 (15.52%) 2.7.6
   70 ( 0.39%) 2.7.7
 2651 (14.89%) 2.7.8
 2771 (15.56%) 2.7.9
 1738 ( 9.76%) 2.7.10
   43 ( 0.24%) 3.2.3
  251 ( 1.41%) 3.3.2
   26 ( 0.15%) 3.3.3
  163 ( 0.92%) 3.4.0
 1282 ( 7.20%) 3.4.1
  502 ( 2.82%) 3.4.2
 1832 (10.29%) 3.4.3
   82 ( 0.46%) other

@13steinj
Copy link
Contributor

I think that the dependencies already support Python 3.5. The Python 3.5 build passes on Travis CI, so this should be a fairly good indication that they do.

They do? Then I have practically no objection to that.

Python 3.2 support was dropped from Coverage 4.0 as is doesn't support unicode literals (see Pep 414). Python 2.6 and 2.7 support it via future.

Good to know.

I don't think that the .travis.yml can be easily extended to install Coverage 3.7.1.

I think that support for Python 3.2 can safely be dropped. The big hurdle is getting people from Python 2.7 to 3.X, but once they're on 3.X upgrading to 3.X+1 is a lot easier. I imagine the majority of people using PRAW on Python 3.X are on 3.4 anyway.

And I agree. I always assumed this to be the case as I've never even heard of people using 3.2 and 2.6 anymore which is why in #530, I made mention that it should either be made supported somehow (in case my assumption was incorrect) or testing be dropped, and according to @bboe 's numbers, they mirrors the assumption I had and it's definitely safe to drop support altogether.

- nightly
- pypy
- pypy3
matrix:
allow_failures:
- python: nightly
- python: 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we completely remove 3.2?

@bboe
Copy link
Member

bboe commented Sep 21, 2015

@JamieMagee thanks for the PR. Can you please make the modifications as per my comments? Also would you be willing to add a changelog entry indicating the drop of support for the two versions, and the addition of 3.5? You can link directly to this PR to provide "more information". Thanks!

@JamieMagee
Copy link
Contributor Author

@bboe Done!

bboe added a commit that referenced this pull request Sep 22, 2015
@bboe bboe merged commit 42e6374 into praw-dev:master Sep 22, 2015
@bboe
Copy link
Member

bboe commented Sep 22, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants