Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Boost as a dependency instead of bundling it #150

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Require Boost as a dependency instead of bundling it #150

merged 3 commits into from
Mar 12, 2024

Conversation

seqre
Copy link
Contributor

@seqre seqre commented Mar 11, 2024 •
edited
Loading

Per internal discussion, I'm moving on with that idea (closes #149).

This PR:

  1. Removes boost/ from the Vectorscan includes directory.
  2. Updates documentation to mention requiring Boost >= 1.57
  3. Updates GitHub Actions workflows and Dockerfiles to download Boost libraries required for compilation

Armada3334
Armada3334 approved these changes Mar 12, 2024
View reviewed changes
Copy link

@Armada3334 Armada3334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bradlarsen bradlarsen merged commit 65f15e4 into praetorian-inc:main Mar 12, 2024
9 checks passed
@seqre seqre deleted the remove-boost branch March 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Armada3334 Armada3334 Armada3334 approved these changes

@bradlarsen bradlarsen bradlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require Boost as a dependency instead of bundling it
3 participants
@seqre @bradlarsen @Armada3334