Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix props & events not falling through to input #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gui-JVale
Copy link

I was about to create a new issue but figured I'd just make a PR instead. Here was the description I was about to leave:

Describe the bug

On the PTextField input component the props, attributes, and event listeners are getting added to the root level element as opposed to the input itself.

Event though those are correctly bound to the input using v-bind and v-on, on the options api the attribute inheritAttrs isn't specified as false, and so it ends up in the root element anyways.

To Reproduce
Steps to reproduce the behavior:

  1. Render a PTextField component and try any events other then @input, like @blur/@Focus out or a [data-attr]
  2. Inspect the DOM and observe that data attributes don't end up in the input
  3. Observe that events other then @input don't get fired

Expected behavior
Props, attrs and listeners should get bound to the input element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant