Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #234

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Update all dependencies #234

merged 6 commits into from
Oct 12, 2020

Conversation

onigoetz
Copy link
Contributor

@onigoetz onigoetz commented Sep 25, 2020

Hello,

I am in the process of creating a few PRs to upgrade to PostCSS8 here and there.

This module doesn't need any special upgrade or breaking change, but since I was in the middle of it I thought I could still finish and send a PR.

This PR contains no breaking change since everything changed is in tests or devDependencies.

Dev dependencies updates include :

  • Replace eslint-plugin-babel with @babel/eslint-plugin
  • Replace babel-eslint with @babel/eslint-parser
  • Upgrade from ava version 1 => 3
  • Upgrade from eslint version 5 => 7
  • Upgrade from semver version 5 => 7
  • Upgrade from postcssversion 7 => 8
  • Upgrade from del-cliversion 1 => 3

@onigoetz
Copy link
Contributor Author

It seems that tests can't run on node 8 and fail with timeouts on 10 / 11

@alexander-akait
Copy link
Collaborator

@onigoetz Feel free remove node@8 from matrix

@onigoetz
Copy link
Contributor Author

Also node 6 ? should it also be updated in package.json ?

@alexander-akait
Copy link
Collaborator

@onigoetz Late, not here

@alexander-akait
Copy link
Collaborator

@onigoetz Do you need help?

@onigoetz
Copy link
Contributor Author

onigoetz commented Oct 2, 2020

Sorry I didn't send a message sooner.
It seems that the tests fail because of a timeout, I don't know exactly why and can't reproduce locally.

I could need help to figure that part out :)

@alexander-akait
Copy link
Collaborator

Maybe just try increase timeout?

@onigoetz
Copy link
Contributor Author

onigoetz commented Oct 2, 2020

yes sure, I just wanted to make it the last resort, not the first thing I try

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.38% when pulling 4cfc7bc on onigoetz:master into 9e798f0 on postcss:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.38% when pulling 4cfc7bc on onigoetz:master into 9e798f0 on postcss:master.

Copy link
Collaborator

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ready to merge or something else?

@onigoetz
Copy link
Contributor Author

I think it's all good

@alexander-akait alexander-akait merged commit 96a85e3 into postcss:master Oct 12, 2020
@alexander-akait
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants