Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostCSS 5.0 #75

Closed
ai opened this issue Aug 22, 2015 · 3 comments
Closed

Use PostCSS 5.0 #75

ai opened this issue Aug 22, 2015 · 3 comments

Comments

@ai
Copy link
Member

ai commented Aug 22, 2015

Seems like postcss.parse broke a AST in PostCSS 5.0 (because your plugin depends on PostCSS 4.x and uses 4.x parser, which generates 4.x nodes).

Can you update PostCSS in dependencies?

/cc @MoOx

@ai
Copy link
Member Author

ai commented Aug 22, 2015

We add special hook fo 4.x plugin in PostCSS 5.0, but I found a bad place in postcss-import:

nodes.splice.apply(nodes, [nodes.indexOf(atRule), 0].concat(newNodes))

By the many reasons, changing nodes directly is not a good way :).

@MoOx
Copy link
Contributor

MoOx commented Aug 25, 2015

I used a low level array manipulation because of all the bug the cloning methods were introducing.

@MoOx
Copy link
Contributor

MoOx commented Sep 13, 2015

Closed by 0626939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants