Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss 5.x support #24

Closed
pirxpilot opened this issue Aug 21, 2015 · 2 comments
Closed

postcss 5.x support #24

pirxpilot opened this issue Aug 21, 2015 · 2 comments

Comments

@pirxpilot
Copy link
Owner

Branch that supports postcss 5.x is here

Among other things it removes support for --safe option. And it requires node >= 0.12
Check it out, send feedback, patches etc. I plan to release it as postcss-cli 2.0.0 if everything works OK.

@FND - if you find a moment could you check if --watch works OK. Thanks!

@FND
Copy link
Contributor

FND commented Aug 21, 2015

Yup, --watch still seems to work alright. However:

  • postcss-import doesn't officially support PostCSS 5.x yet, so I had to manually remove that outdated package (i.e. rm -r node_modules/postcss-import/node_modules/postcss).¹ My project still seems to compile just fine afterwards.
  • After doing so, make test-watch also succeeded, whereas before I just got some cryptic error.

¹ Thankfully, PostCSS emitted a helpful warning: "Your current PostCSS version is 5.0.1, but postcss-import uses 4.1.16. Perhaps this is the source of the error below."

@pirxpilot
Copy link
Owner Author

Thanks! Looks like postcss-import 5.x compatibility issues is now tracked: postcss/postcss-import#75
I'll add a workaround to Readme for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants