fix: add support for svh, lvh, dvh, svw, lvw, dvw, svmin, lvmin, dvmin, svmax, lvmax, dvmax units

[geecko86]

... as well as vb, svb, lvb, dvb, vi, svi, lvi, dvi.

fix #217

I didn't add tests since you don't have any that's specific to vh and vw.

[ludofischer]

Thank you! I think we need to still regenerate the parser.

[geecko86]

Thank you! I think we need to still regenerate the parser.

Sorry I'm not familiar enough with the project - not sure I understand. Anything I can assist you with?

Also, would you kindly provide an ETA for a push of this commit to production? Thank you

[ludofischer]

Could you maybe post some sample CSS that you tried to parse, so I can add some tests, just to make sure we don't forget about it if we ever change the parser?
I realized after that nothing needs to be done with the parser is because the parser JavaScript code that runs when the plugin is used is generated from the grammar in the .jison file, but the generated parser code is not committed to the repository, instead the generator runs during the prepare which should run when someone publishes.

[geecko86]

Sure. Here are the lines the plugin is outputting as errors/warning for my project:

Code:
  max-height:calc(98% - 1.5rem - (85svh/8.2 + 1.9rem + 1.65svh))!important
Code:
  padding:calc(1.9rem + 1.6svh) 0 0 0
Code:
  max-width:calc(100% - 2.75svh)
Code:
  bottom:calc(var(--table_height) + (50svmax - 42.5svmax) - (75svmax * .8))!important
Code:
  gap:calc(153.5svmax - var(--lamp-width))
Code:
  padding-left:calc(100svmax - 44.5svh)
Code:
  padding-left:calc(100svmax - 44.5svmin)
Code:
  max-height:calc(98% - 1.5rem - (85svh/8.2 + 1.9rem + 1.65svh))!important
Code:
  padding:calc(1.9rem + 1.6svh) 0 0 0
Code:
  max-width:calc(100% - 2.75svh)
Code:
  bottom:calc(var(--table_height) + (50svmax - 42.5svmax) - (75svmax * .8))!important
Code:
  gap:calc(153.5svmax - var(--lamp-width))
Code:
  padding-left:calc(100svmax - 44.5svh)

the generator runs during the prepare which should run when someone publishes.

Sorry to insist, but do you have a broad estimation of when that might happen? Thank you.

[ludofischer]

Sorry to insist, but do you have a broad estimation of when that might happen? Thank you.

If you really need immediately I could do it this evening or tomorrow.

Is this issue preventing the minification to complete? I think it's supposed to skip minifying the code it does not understand and output a warning, but it should not crash the program. Or is the warning itself a a problem?

[geecko86]

You're correct. The warning is not a problem in itself. I do however need to minify as much code as possible and was under the assumption that the plugin skipping lines was probably hurting its effectiveness.

If you really need immediately I could do it this evening or tomorrow.

That's very kind, thank you. I certainly don't mean to be pushy - but yeah when you have a moment for this, it would be much appreciated.