Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: add quick-input POM #5770

Merged
merged 4 commits into from
Dec 17, 2024
Merged

e2e-test: add quick-input POM #5770

merged 4 commits into from
Dec 17, 2024

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Dec 17, 2024

  • Copied over original QuickInput POM and refactored to PositronQuickInput leveraging the Playwright API.
  • Updated existing logic in tests to use PositronQuickInput instead.

QA Notes

Ran all linux tests: https://github.com/posit-dev/positron/actions/runs/12373090485

Copy link

github-actions bot commented Dec 17, 2024

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@midleman midleman marked this pull request as ready for review December 17, 2024 15:20
@midleman midleman requested a review from testlabauto December 17, 2024 15:20
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@midleman midleman merged commit ae95182 into main Dec 17, 2024
6 checks passed
@midleman midleman deleted the mi/quick-input branch December 17, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants