Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-13 to avoid errors setting up Python #2879

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Use macos-13 to avoid errors setting up Python #2879

merged 2 commits into from
Apr 26, 2024

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Apr 24, 2024

Intent

Describe briefly what problem this pull request resolves, or what new feature it introduces. Include screenshots of any new or altered UI. Link to any GitHub issues that are related.

Addresses #2874

Approach

Describe the approach taken and the tradeoffs involved if non-obvious; add an overview of the solution if it's complicated.

macOS-latest now runs on arm64 but that image does not install Python 3.9 : actions/runner-images#9770

We set our runner to the macOS-13 image, that should run on x64 which has older python versions installed.

Also moved to macOS-12 for the TypesScript tests as this is the version it last passed

QA Notes

Add additional information for QA on how to validate the change, paying special attention to the level of risk, adjacent areas that could be affected by the change, and any important contextual information not present in the linked issues.

@dfalbel dfalbel requested review from isabelizimm and seeM and removed request for isabelizimm April 24, 2024 20:03
Copy link
Collaborator

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is currently broken without this, so I think it is fine to pin these versions of the OS until we track down the issue.

@petetronic petetronic merged commit b041c55 into main Apr 26, 2024
24 checks passed
@petetronic petetronic deleted the ci/macos-13 branch April 26, 2024 21:20
@juliasilge juliasilge mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants