-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connections pane disconnected state #2810
Conversation
extensions/positron-python/python_files/positron/positron_ipykernel/inspectors.py
Show resolved
Hide resolved
extensions/positron-python/python_files/positron/positron_ipykernel/inspectors.py
Outdated
Show resolved
Hide resolved
extensions/positron-python/python_files/positron/positron_ipykernel/connections.py
Show resolved
Hide resolved
4dd97bf
to
564d6b3
Compare
Tests are currently failing due to actions/runner-images#9770 |
as connections are not copiable, they don't get compared by value.
Co-authored-by: Isabel Zimmerman <[email protected]> Signed-off-by: Daniel Falbel <[email protected]>
564d6b3
to
d2d4d7b
Compare
removeFromHistory(item: DisconnectedConnectionItem) { | ||
this.context.workspaceState.update(item.name, undefined); | ||
this._connections = this._connections.filter((connection) => { | ||
return connection.name !== item.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to match on name here? (seems like we could have two connections with the same name but different ids)
Co-authored-by: Jonathan <[email protected]> Signed-off-by: Daniel Falbel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for both types of sqllite connections 👍
Intent
Adds a disconnected state for the connections pane, with some UI for users to reconnect a closed connection.
Addresses #2739
Also addresses #2756
We are also addressing: #2792
Approach
QA Notes
Screen.Recording.2024-04-22.at.17.03.50.mov