Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #37 #38

Closed
wants to merge 1 commit into from
Closed

Fix #37 #38

wants to merge 1 commit into from

Conversation

barneycarroll
Copy link
Contributor

Removed the erroneous key-value pair splitting on newlines

I'll clean this up and persist later, but essentially... It works!

Removed the erroneous key-value pair splitting on newlines
@fuzetsu
Copy link
Contributor

fuzetsu commented Nov 22, 2018

Doesn't this break one of the main advertised syntaxes for bss, lean strings?

b`
  background-color black
  text-align center
`

This would be a breaking change that makes bss strings require semicolons.
I usually leave off both the colon and the semicolon when using bss.

@fuzetsu
Copy link
Contributor

fuzetsu commented Nov 22, 2018

Maybe bss should detect the presence of semicolons in the string and dynamically choose the separator?

@porsager
Copy link
Owner

Yeah, we can't kill sloppy mode..

@fuzetsu that might be a way, but it'd be nicer if we could allow anything.. Perhaps a lookup in the proporty list for every first word on a line to decide if it's a new property..

@porsager
Copy link
Owner

@barneycarroll I'm not sure what's the convention around pull requests and alternative fixes... Would it have been more right if I had suggested my fix here so you could add it in this pull request?

@barneycarroll
Copy link
Contributor Author

I'm not sure what's the convention around pull requests and alternative fixes

See you in court next year? ;P

I'm happy there's a better fix, thanks!

@porsager
Copy link
Owner

Hehe.. I'd love that ;)

I've released 1.4.0 with various other improvements as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants