Release 1.3.4

[ggwpez]

Release for the updated inflation formula from #471

This release only affects the Polkadot runtime.

[acatangiu]

Doesn't it need a spec bump to the Polkadot Relay Chain runtime?

[acatangiu]

According to the CHANGELOG the only diff between 1.3.3 and this proposed 1.3.4 is:

Change Polkadot inflation to 120M DOT per year (#471)

So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.

[ggwpez]

So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.

Yes true. We did partial bumps in the past, and it then becomes difficult to know what runtimes need to be bumped to what version on the next release.
Bumping all to 1.3.4 in the 1.3.4 release keeps the rule simple - just bump all to the release version.

[acatangiu]

Releasing same runtime again but with a different spec version is not cool IMO. It adds unnecessary operational overhead to do useless runtime upgrades.

I suggest we achieve what you describe by bumping all relevant runtimes to latest spec version.

In this case, only Polkadot Relay gets 1.3.4. E.g. later say we want to release AH runtime, it would get 1.3.5 (and so will any other runtime that gets changes between now and then).

difficult to know what runtimes need to be bumped to what version on the next release

"what runtimes" -> check the changelog or git history
"what version" -> always use next "globally unique" version (1.3.4 now, next 1.3.5 or 1.4.0)

[ggwpez]

It adds unnecessary operational overhead to do useless runtime upgrades.

We dont upgrade them. They are just deleted from the release page. But it makes it simpler to ctrl+f update them all.

"what version" -> always use next "globally unique" version (1.3.4 now, next 1.3.5 or 1.4.0)

Yea we can also do that. Will change now to get this merged.

[seadanda]

Do we need to re-run benchmarks for MQ bump? AHK and Encointer bumps LGTM

[acatangiu]

To pick up this fix for other runtimes we need to bump them too. Not sure if the fix is urgent, if the other system chains have any overweight stuck messages in the queue.
But if they don't, I don't personally think it's worth the runtime upgrade, and we can go without bumping them.

[ggwpez]

Good Q. I think it should be fine to only bump PAH. Last time we checked it was only Hydra affected (Astar was false positive).

[ggwpez]

/merge

[fellowship-merge-bot]

Enabled auto-merge in Pull Request

Available commands

• /merge: Enables auto-merge for Pull Request
• /merge cancel: Cancels auto-merge for Pull Request
• /merge help: Shows this menu

For more information see the documentation