Switch Collectives Slash Handler to Use Limited Teleport Assets #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
changed the title
|
any regression tests? |
There is already a test. It failing is what flagged the problem. |
kianenigma
approved these changes
Oct 17, 2023
Correct, it's also within system logic (called in a slash handler). This is not user-accessible. |
Closed
acatangiu
approved these changes
Oct 17, 2023
KiChjang
approved these changes
Oct 17, 2023
ggwpez
approved these changes
Oct 17, 2023
bkchr
approved these changes
Oct 18, 2023
|
/merge |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teleport_assetsis marked as deprecated and the message fails to execute on the Relay Chain due to incorrect weight. This migrates tolimited_teleport_assetswith anUnlimitedweight limit.I added the note to the CHANGELOG for the 1.0.0 release, as I don't think this release should be published without this change. I can create a 1.0.1 section instead if people want that.