-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MetadataHash calculation on Build to Kusama People chain #371
Merged
fellowship-merge-bot
merged 8 commits into
polkadot-fellows:main
from
SBalaguer:sb-hashonbuild-people
Jul 24, 2024
Merged
Adds MetadataHash calculation on Build to Kusama People chain #371
fellowship-merge-bot
merged 8 commits into
polkadot-fellows:main
from
SBalaguer:sb-hashonbuild-people
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you should add a changelog entry. |
Joe suggested the same, under ###FIXED. Just added it. |
bkchr
approved these changes
Jul 2, 2024
skunert
approved these changes
Jul 2, 2024
Review required! Latest push from author must always be reviewed |
bkchr
reviewed
Jul 2, 2024
xlc
approved these changes
Jul 3, 2024
/merge |
/merge |
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit Jul 24, 2024
7674917
into
polkadot-fellows:main
42 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the calculation of the MetadataHash upon build in the Kusama People Chains Runtime. I don't think this needs a CHANGELOG entry, but I could be mistaken.