Add XcmPaymentApi and DryRunApi to all runtimes #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
changed the title
xlc
approved these changes
Jun 26, 2024
|
We could put this against master and merge it after the 1.13 bump, to not blow up that huge PR even further |
|
Review required! Latest push from author must always be reviewed |
|
Had to add them to coretime-kusama as well |
|
@franciscoaguirre SDK bump complete. You can now change the base branch to |
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Adds the paritytech/polkadot-sdk#3607 and paritytech/polkadot-sdk#3872 to all runtimes. These APIs work together to allow dry running and estimating execution and delivery fees for XCMs. This PR doesn't allow querying the price in assets different than the relay token for asset hubs. Can be done in a following PR. Also tracking #388 and #389 for future improvemens. Old PR was #359, this one targets main already updated to Polkadot SDK 1.13. ## Dear reviewer Although there are a lot of changes, the main one is the addition of the two aforementioned APIs to all relays and system parachains. The rest of the files are tests, which all have the same format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
We should merge this PR to main ONLY after merging the update to 1.13.
Content
Adds the XcmPaymentApi and DryRunApi to all runtimes.
These APIs work together to allow dry running and estimating execution and delivery fees for XCMs.
This PR doesn't allow querying the price in assets different than the relay token for asset hubs. Can be done in a following PR.