Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast Fellowship Promote Tracks #356

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jun 24, 2024

Add fast promotion tracks with 7 days (instead of 30 days) voting period.
The tracks have a 50% turnout and 66% approval criteria. To be used in combination with paritytech/polkadot-sdk#4778.

It could be that the 50% turnout is too much for tracks I and II, but for III there are not so many fellows so we can expect them to all vote IMHO.

ggwpez added 2 commits June 24, 2024 17:29
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez changed the title Oty fast track promote origin Fast Fellowship Promote Tracks Jun 24, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
const FAST_PROMOTE_MAX_DECIDING: u32 = 10;
const FAST_PROMOTE_DECISION_DEPOSIT: Balance = 5 * DOLLARS;
const FAST_PROMOTE_PREPARE_PERIOD: BlockNumber = 0;
const FAST_PROMOTE_DECISION_PERIOD: BlockNumber = 7 * DAYS;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if this is too short? The origin is already "faster" since it can bypass the promotion period.
On the other hand, with the high turnout it will rather error on the side of rejecting so maybe its fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue is having to wait for years to get to a correct level.

If this can bypass the promotion min period, I don't see the need to have it faster than the "normal" 30 days, I don't expect members to find 30 days too slow..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue is having to wait for years to get to a correct level.

Yeah that needs to be fixed by making a call in Core Fellowship that will respect this origin.

Dunno if this is too short?

I think it is OK, could also go in the middle with something like 14 days.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions, so changed to 30 days after internal discussion.

@joepetrowski joepetrowski mentioned this pull request Jun 25, 2024
9 tasks
@ggwpez ggwpez mentioned this pull request Jul 17, 2024
@ggwpez
Copy link
Member Author

ggwpez commented Aug 2, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) August 2, 2024 14:54
@fellowship-merge-bot fellowship-merge-bot bot merged commit 5ecaca1 into main Aug 2, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants