Enable 6 second block times for people chain
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
May 27, 2024
|
Review required! Latest push from author must always be reviewed |
ordian
approved these changes
Jun 9, 2024
joepetrowski
approved these changes
Jun 12, 2024
Comment on lines
+103
to
+105
| /// Maximum number of blocks simultaneously accepted by the Runtime, not yet included | ||
| /// into the relay chain. | ||
| pub const UNINCLUDED_SEGMENT_CAPACITY: u32 = 2; |
There was a problem hiding this comment.
This seems pretty conservative. What is the tradeoff with higher values? More forks?
IMO in general we should on Kusama be a little more aggressive with parameterization. If that doesn't apply to this value, ignore :).
There was a problem hiding this comment.
IIUC higher values don't make real sense if we're targeting 6 seconds with velocity == 1. I mean, we can set it higher, but we'll still be getting 6 seconds %)
…-blocktime-people
Co-authored-by: joe petrowski <[email protected]>
…ople' into s0me0ne/enable-6sec-blocktime-people
ordian
approved these changes
Jun 12, 2024
joepetrowski
approved these changes
Jun 12, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
ordian
approved these changes
Jun 19, 2024
sandreim
approved these changes
Jun 20, 2024
fellowship-merge-bot
bot
merged commit bd1759c
into
polkadot-fellows:main
40 of 41 checks passed
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Encointer communities could benefit from 6s block time because the network is used for IRL point-of-sale or person-to-person transactions Encointer is unaffected by paritytech/polkadot-sdk#3268 as its pallets have since ever based time on block timestamps The parameters are copy-paste from people, as introduced by #308 --------- Co-authored-by: joe petrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an excerpt from #266. It aims to enable 6-second block times for
peopleparachain only.If I'm not missing anything, the
peopleparachain is the only parachain not affected by paritytech/polkadot-sdk#3268, and thus, 6-second block times may be enabled without breaking something.This PR was tested locally using the
kusama-localrelay chain. The time of the session within which the runtime upgrade was enacted expectedly deviated, but other than that, no problems were observed.