Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XCM SafeCallFilter for chains using Weights::v2 #285

Merged

Conversation

acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Apr 24, 2024

Remove SafeCallFilter from system chains as they all now use Weights::v2 which already accounts for call PoV size. This effectively removes artificial limitations on what users canXCM::Transact on these chains (blockspace limitations are still upheld).

Fixes #273

@joepetrowski joepetrowski mentioned this pull request Apr 25, 2024
10 tasks
@acatangiu acatangiu force-pushed the remove-safe-call-filter branch from acb9729 to 51179d7 Compare April 29, 2024 15:47
Remove `SafeCallFilter` from system chains as they all now use
Weights::v2 which already accounts for call PoV size. This effectively
removes artificial limitations on what users can`XCM::Transact`
on these chains (blockspace limitations are still upheld).
@acatangiu acatangiu force-pushed the remove-safe-call-filter branch from 51179d7 to 3aa6ef3 Compare April 29, 2024 15:49
@acatangiu
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) May 7, 2024 08:17
auto-merge was automatically disabled May 7, 2024 10:56

Head branch was pushed to by a user without write access

@acatangiu
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit d57f962 into polkadot-fellows:main May 7, 2024
35 of 36 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove XCM SafeCallFilter for chains using Weights::v2 (also accounting PoV weight)
4 participants