Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DMP Queue and Allow system::authorize_upgrade in XCM #280

Merged

Conversation

joepetrowski
Copy link
Contributor

Allow using system::authorize_upgrade as parachain_system's is deprecated.

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I see the other system parachains already have it on the safe list 👍

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which context is this used?

@joepetrowski
Copy link
Contributor Author

In which context is this used?

Upgrading parachains

@bkchr
Copy link
Contributor

bkchr commented Apr 23, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) April 23, 2024 22:25
@bkchr
Copy link
Contributor

bkchr commented Apr 24, 2024

@joepetrowski You need to remove the dmp-queue pallet from the runtimes the check is failing for.

auto-merge was automatically disabled April 24, 2024 13:08

Head branch was pushed to by a user without write access

@joepetrowski joepetrowski changed the title Allow system::authorize_upgrade in XCM Remove DMP Queue and Allow system::authorize_upgrade in XCM Apr 24, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@bkontur
Copy link
Contributor

bkontur commented Apr 24, 2024

Don't we need to add migration RemovePallet everywhere?

	frame_support::migrations::RemovePallet<DmpQueueName, RocksDbWeight>,

like Basti did here: https://github.com/polkadot-fellows/runtimes/pull/277/files#diff-da00a6055ce091ceb6769ed5cc0dc6527aca586de0394a60aa3d18c38ff89716R140 for AssetHubs and BridgeHubs ?

@joepetrowski
Copy link
Contributor Author

@bkchr @kianenigma @acatangiu @muharem can you take another look? Larger changes since just adding these two calls to the filter.

@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 5cf99f3 into polkadot-fellows:main Apr 24, 2024
38 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@joepetrowski joepetrowski deleted the safe-call-system branch April 24, 2024 15:19
@bkontur bkontur mentioned this pull request Aug 12, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants