[encointer] introduce collator selection and send fees to authors instead of treasury #270

brenzi · 2024-04-10T11:32:26Z

closes #183
closes #176
closes #146 (should be closed already, but this PR adds more)

This PR aligns collator selection and fee distribution logic of Encointer with other system chains and thereby is a small step towards self-sustainability of infrastructure

remove treasury (and leave negligible funds on trsry account)
add collator-selection, session and authorship pallets
instead of burning fees in community currency , send them to block authors like native KSM
remove DMP queue pallet (pure cleanup, no change in functionality)
add migration to inject existing collators as invulnerables
remove applied migrations from release 1.2.0

steps to reproduce the new fee logic: https://gist.github.com/brenzi/ca9e0c326198c73ff2dd0a2e74468053

system-parachains/encointer/src/migrations_fix.rs

system-parachains/encointer/src/lib.rs

system-parachains/encointer/src/migrations_fix.rs

brenzi · 2024-04-18T13:39:56Z

darn. that was a mistake...

Co-authored-by: joe petrowski <[email protected]>

…e initial session keys

brenzi · 2024-05-01T13:42:57Z

I would claim your feedback up to this point has been addressed @joepetrowski. thanks a lot for your hints

joepetrowski

KSM does go to the Staking Pot as expected:
https://gist.github.com/brenzi/ca9e0c326198c73ff2dd0a2e74468053#file-gistfile1-txt-L50-L64

brenzi · 2024-05-07T11:31:45Z

/merge

fellowship-merge-bot · 2024-05-07T11:41:32Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

fellowship-merge-bot · 2024-05-07T11:53:43Z

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

fellowship-merge-bot · 2024-05-07T13:22:02Z

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

…or-selection

CHANGELOG.md

acatangiu · 2024-05-21T12:46:58Z

/merge

fellowship-merge-bot · 2024-05-21T12:48:40Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

brenzi · 2024-05-22T19:01:03Z

happy to announce the migration worked smoothly on rococo and the session pallet works as expected:

notice the author's appearing after the upgrade

migration log

May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.173  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "Authorship" detected in the runtime. The pallet has no defined storage version, so the on-chain version is being initialized to StorageVersio>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.174  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "CollatorSelection" detected in the runtime. Initializing the on-chain storage version to match the storage version defined in the pallet: Sto>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.174  INFO tokio-runtime-worker runtime::frame-support: [Parachain] 🐥 New pallet "Session" detected in the runtime. Initializing the on-chain storage version to match the storage version defined in the pallet: StorageVersio>
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.180  INFO tokio-runtime-worker frame_support::migrations: [Parachain] Removed 1 DmpQueue keys 🧹
May 22 18:58:18 ero-collator-02 encointer-collator[3797498]: 2024-05-22 18:58:18.180  INFO tokio-runtime-worker runtime::fix::collator_selection_init: [Parachain] initializing the set of invulnerables

brenzi and others added 15 commits April 9, 2024 16:11

3 new pallets for collator selection. copy-paste from AH

8ad5ba5

remove DMP queue pallet

8715796

add encointer invulnerables for testnet genesis

f70d07d

remove treasury pallet and grant fees to collator pot instead

5e81b71

send fees in CC to block author

0748d86

fmt

d8f179c

add changelog

27b70e0

taplo fmt

034662a

taplo fmt

d5a6362

revert formatting

6a03ceb

cleanup changelog formatting

0ed6eac

align taplo fmt

aa4a013

align taplo fmt

ff96d4d

Merge branch 'main' into ab/introduce_collator-selection

ebdde4f

add migration to initialize invulnerables

20edb93

brenzi commented Apr 10, 2024

View reviewed changes

system-parachains/encointer/src/migrations_fix.rs Show resolved Hide resolved

brenzi added 2 commits April 10, 2024 17:42

fix no_std build

e252e42

fix chainspec-generator

264d867

brenzi mentioned this pull request Apr 10, 2024

introduce collator-selection and remove treasury encointer/encointer-parachain#219

Merged

fix benchmarks build

ad8733e

brenzi marked this pull request as ready for review April 10, 2024 18:04

zepter fix

8e5f948

brenzi mentioned this pull request Apr 10, 2024

Encointer checks/improvements #199

Open

3 tasks

clangenb reviewed Apr 15, 2024

View reviewed changes

system-parachains/encointer/src/lib.rs Outdated Show resolved Hide resolved

Merge branch 'main' into ab/introduce_collator-selection

db32586

joepetrowski reviewed Apr 17, 2024

View reviewed changes

brenzi closed this Apr 18, 2024

brenzi force-pushed the ab/introduce_collator-selection branch from db32586 to 31ba262 Compare April 18, 2024 13:38

brenzi reopened this Apr 18, 2024

brenzi and others added 5 commits May 1, 2024 11:56

Update system-parachains/encointer/src/migrations_fix.rs

7a09130

Co-authored-by: joe petrowski <[email protected]>

inject fresh invulnerable accounts. leave existing aura keys to becom…

a9f4d16

…e initial session keys

fix mappings between session and validator keys

963b2a3

split CC fees between author and a dead account (burn)

6a75792

Merge branch 'main' into ab/introduce_collator-selection

9f5be6d

brenzi mentioned this pull request May 2, 2024

test collator-selection on rococo encointer/encointer-parachain#222

Closed

13 tasks

Merge branch 'main' into ab/introduce_collator-selection

1a65536

liamaharon mentioned this pull request May 7, 2024

Investigate report of TI not updating as expected when block reward fee is partially burned paritytech/polkadot-sdk#4397

Open

joepetrowski approved these changes May 7, 2024

View reviewed changes

Merge branch 'main' into ab/introduce_collator-selection

b6231a6

fellowship-merge-bot bot enabled auto-merge (squash) May 7, 2024 11:41

Merge branch 'main' into ab/introduce_collator-selection

d6bc232

auto-merge was automatically disabled May 8, 2024 11:56
Head branch was pushed to by a user without write access

brenzi added 2 commits May 21, 2024 09:23

Merge remote-tracking branch 'upstream/main' into ab/introduce_collat…

fb090ed

…or-selection

clippy after merge

782d5a9

acatangiu approved these changes May 21, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

brenzi added 2 commits May 21, 2024 13:28

Merge branch 'main' into ab/introduce_collator-selection

201a36d

fix changelog

343e93e

acatangiu approved these changes May 21, 2024

View reviewed changes

fellowship-merge-bot bot enabled auto-merge (squash) May 21, 2024 12:48

fellowship-merge-bot bot merged commit 2fe6f56 into polkadot-fellows:main May 21, 2024
38 checks passed

brenzi mentioned this pull request Jun 4, 2024

test collator selection on paseo integritee-network/parachain#295

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[encointer] introduce collator selection and send fees to authors instead of treasury #270

[encointer] introduce collator selection and send fees to authors instead of treasury #270

brenzi commented Apr 10, 2024 •

edited

Loading

brenzi commented Apr 18, 2024

brenzi commented May 1, 2024

joepetrowski left a comment

brenzi commented May 7, 2024

fellowship-merge-bot bot commented May 7, 2024

fellowship-merge-bot bot commented May 7, 2024

fellowship-merge-bot bot commented May 7, 2024

acatangiu commented May 21, 2024

fellowship-merge-bot bot commented May 21, 2024

brenzi commented May 22, 2024 •

edited

Loading

[encointer] introduce collator selection and send fees to authors instead of treasury #270

[encointer] introduce collator selection and send fees to authors instead of treasury #270

Conversation

brenzi commented Apr 10, 2024 • edited Loading

brenzi commented Apr 18, 2024

brenzi commented May 1, 2024

joepetrowski left a comment

Choose a reason for hiding this comment

brenzi commented May 7, 2024

fellowship-merge-bot bot commented May 7, 2024

fellowship-merge-bot bot commented May 7, 2024

Failed to update PR ❌

fellowship-merge-bot bot commented May 7, 2024

Failed to update PR ❌

acatangiu commented May 21, 2024

fellowship-merge-bot bot commented May 21, 2024

brenzi commented May 22, 2024 • edited Loading

brenzi commented Apr 10, 2024 •

edited

Loading

brenzi commented May 22, 2024 •

edited

Loading