Change Asset Class Creation Deposits #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
commented
Mar 28, 2024
| @@ -52,7 +52,7 @@ frame_support::parameter_types! { | |||
| pub UncongestedMessage: Xcm<()> = build_congestion_message(false).into(); | |||
|
|
|||
| /// Should match the `AssetDeposit` of the `ForeignAssets` pallet on Asset Hub. | |||
| pub const CreateForeignAssetDeposit: u128 = 10 * UNITS; | |||
| pub const CreateForeignAssetDeposit: u128 = system_para_deposit(1, 190); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
190 is based on the bytes? there should be some way to get that number without hardcoding no?
with max_encoded_len?
There was a problem hiding this comment.
It is the encoded length of AssetDetails in this configuration.
I'm not sure if we can use max_encoded_len here? ( @ggwpez ?) I calculated it by writing a test and asserting encoded_len.
There was a problem hiding this comment.
If you remove the const it should work.
shawntabrizi
approved these changes
Mar 28, 2024
muharem
approved these changes
Mar 28, 2024
claravanstaden
approved these changes
Mar 28, 2024
|
/merge |
bkchr
approved these changes
Mar 28, 2024
|
/merge |
fellowship-merge-bot
bot
merged commit 256059b
into
polkadot-fellows:main
36 of 37 checks passed
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the asset class creation deposits to use standard storage deposit functionality.
Similar to #237