Keep im-online events decodable after pallet removal
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
approved these changes
Mar 13, 2024
Yes, I reproduced the problem in a local synthetic test and made sure it was resolved with this patch. Paths do not matter, TypeInfo only includes names, I'm not sure it's even critical in this case, but I still named the thing |
ordian
approved these changes
Mar 15, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 64c9e16
into
polkadot-fellows:main
29 of 30 checks passed
Fair enough, raised #242 |
|
Thank you! Good approach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #178, which aims to keep the
im-onlinepallet events decodable after the pallet itself is removed.As discussed, the inability to decode events may result in missing a candidate in approval voting and a parachain finality stall. Although the circumstances of such an event are unlikely, it's better to safeguard them.
The transient code introduced in this PR should be removed after the upgrade is enacted.