Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary skip Encointer check-migrations (TODO: https://github.com/polkadot-fellows/runtimes/issues/186) #207

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Feb 29, 2024

  • Does not require a CHANGELOG entry

@@ -106,8 +106,17 @@ jobs:

echo "Flags: $EXTRA_FLAGS"

if [[ "${{ matrix.runtime.name }}" == "encointer-kusama" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just un-require it for merge.

@ggwpez
Copy link
Member

ggwpez commented Feb 29, 2024

@bkchr could you please un-require the check-migrations encointer for merge?

@bkontur
Copy link
Contributor Author

bkontur commented Feb 29, 2024

@bkchr could you please un-require the check-migrations encointer for merge?

Haha :D, that's actually what I suggested before. However, after Basti's comment, I got the impression that it needs to be done here and not in the GitHub configuration.

Anyway, looks like this hack works: https://github.com/polkadot-fellows/runtimes/actions/runs/8097358985/job/22128262518?pr=207 :D

@ggwpez
Copy link
Member

ggwpez commented Feb 29, 2024

Hm i see. I think having it red to still remind us of fixing is still better than having it display green while not working.

@bkchr
Copy link
Contributor

bkchr commented Feb 29, 2024

Hm i see. I think having it red to still remind us of fixing is still better than having it display green while not working.

Yeah good idea. Removed the check from the required checks.

@bkchr bkchr closed this Feb 29, 2024
@bkontur bkontur deleted the bko-skip-encointer-check-migrations-tmp branch February 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants