Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable elastic scaling node side feature on Kusama #205

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Feb 28, 2024

This feature is required for Kusama to ensure that Parachains that have multiple cores assigned, still be able to include at least one block. The relay chain itself doesn't support Parachains with multiple cores assigned right now, but this will come in later updates.

  • Does not require a CHANGELOG entry

This feature is required for Kusama to ensure that Parachains that have
multiple cores assigned, still be able to include at least one block.
Comment on lines 1747 to 1748
let _ = Configuration::set_node_feature(RawOrigin::Root.into(), 1, true);
Weight::from_parts(1, 0)
Copy link
Contributor

@ordian ordian Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we not returning the actual weight of the extrinsic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the function doesn't return it, but I got some idea

@eskimor eskimor mentioned this pull request Mar 5, 2024
19 tasks
@ordian
Copy link
Contributor

ordian commented Mar 8, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) March 8, 2024 10:05
@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot fellowship-merge-bot bot merged commit f5aeb7e into main Mar 9, 2024
29 of 30 checks passed
@bkchr bkchr deleted the bkchr-elastic-scaling-node-feature branch March 9, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants