Treasury Pallet Account as destination for XCM fees on System Parachains #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Feb 20, 2024
Szegoo
reviewed
Feb 20, 2024
Co-authored-by: Sergej Sakac <[email protected]>
…unt-on-system-chains
Szegoo
approved these changes
Feb 21, 2024
…unt-on-system-chains
joepetrowski
approved these changes
Mar 5, 2024
2 tasks
|
/merge |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
|
/merge |
|
@Bullrich what does this mean? I see this log: |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
From the docs, it seems that unstable is when the PR can be merged but not all of the commits passed. It's clearly caused by this: I'll modify the action so it can handle unstable actions too |
|
Added issue to track this problem: |
bkchr
pushed a commit
that referenced
this pull request
Mar 18, 2024
Asset Conversion instance for Polkadot Asset Hub and XCM Swap Weight Trader for both Asset Hubs. TODO: - [x] update treasury account when this PR merged - #191 - [x] define account deposit for pool assets, liquidity withdrawal fee, pool setup fee; --------- Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Sergej Sakac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designates the Treasury Pallet Account as the destination for XCM fees on System Parachains.
This ensures that assets accumulated in the pallet's account can be spent by Treasury Origins from Relay Chains.