Introduce collectives_polkadot_runtime_constants and removed hard-coded numbers usage for indexes
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oded numbers usage for indexes
acatangiu
approved these changes
Feb 13, 2024
system-parachains/collectives/collectives-polkadot/constants/src/lib.rs
Outdated
Show resolved
Hide resolved
…ives-constants-todo
…ives-constants-todo
acatangiu
approved these changes
Mar 1, 2024
bkchr
approved these changes
Mar 11, 2024
integration-tests/emulated/tests/assets/asset-hub-polkadot/Cargo.toml
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/constants/src/lib.rs
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/constants/Cargo.toml
Outdated
Show resolved
Hide resolved
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit cc43238
into
polkadot-fellows:main
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves older TODO + addresses #109 (comment).