Remove state trie migration from kusama, add it to polkadot #170
Conversation
|
We can dry-run this with chopsticks since it exposes a dev-rpc to mint new blocks. |
Would be nice. For the kusama one my main worry was that the migration would consume too much weight on the block, is there a way to get the remaining weight in each block with chopstick (I do not know chopstick at all)? |
|
No i dont think it can print anything. But you can subscribe on |
| @@ -1626,9 +1606,6 @@ construct_runtime! { | |||
| Auctions: auctions::{Pallet, Call, Storage, Event<T>} = 72, | |||
| Crowdloan: crowdloan::{Pallet, Call, Storage, Event<T>} = 73, | |||
|
|
|||
| // State trie migration pallet, only temporary. | |||
| StateTrieMigration: pallet_state_trie_migration = 98, | |||
There was a problem hiding this comment.
We probably need to write some migration to remove all the old pallet storage items? There already exists the RemovePallet migration that we can use for this.
There was a problem hiding this comment.
yes I will try to use the code we ran on westend
For the relay chain this isn't really a big problem, because we can also build a block that takes slightly longer. |
Co-authored-by: Bastian Köcher <[email protected]>
relay/kusama/src/lib.rs
Outdated
| @@ -1671,6 +1648,7 @@ pub mod migrations { | |||
|
|
|||
| /// Unreleased migrations. Add new ones here: | |||
| pub type Unreleased = ( | |||
| crate::clean_state_migration::CleanMigrate, | |||
There was a problem hiding this comment.
| crate::clean_state_migration::CleanMigrate, | |
| frame_support::migrations::RemovePallet<StateTrieMigrationName, RocksDbWeight>, |
relay/kusama/src/lib.rs
Outdated
| @@ -2714,63 +2692,45 @@ mod remote_tests { | |||
| } | |||
| } | |||
|
|
|||
| mod init_state_migration { | |||
| mod clean_state_migration { | |||
There was a problem hiding this comment.
Now you can remove all of this code.
There was a problem hiding this comment.
whoa looks amazing, thx
ggwpez
changed the title
|
@kianenigma please also review this pr ;) |
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 360581f
into
polkadot-fellows:main
This PR add the state trie migration to V1 to polkadot runtime.
The configuration is the same as the one that was run on kusama.
As in kusama this PR changes the state-trie-version to v1, so the migration declared in unreleased Have to run with the next upgrade. In case the migration is not include, the line
state_version: 1have to be roll back tostate_version: 0as warpsync will stop working until the end of the migration.