Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old Construct Runtime Syntax #152

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Remove Old Construct Runtime Syntax #152

merged 6 commits into from
Jan 31, 2024

Conversation

joepetrowski
Copy link
Contributor

@joepetrowski joepetrowski commented Jan 20, 2024 •
edited by bkchr
Loading

Test

  • Does not require a CHANGELOG entry

ggwpez
ggwpez approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine without Changelog.

kianenigma
kianenigma approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hope we move to the beautiful paritytech/polkadot-sdk#1378 soon.

@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

There was a problem running the action.

❌😵❌

Please find more information in the logs.

@bkchr
Copy link
Contributor

bkchr commented Jan 30, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 30, 2024 14:42
@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 16635f6 into polkadot-fellows:main Jan 31, 2024
15 checks passed
@joepetrowski joepetrowski deleted the new-construct-runtimes branch January 31, 2024 16:34
@Bullrich Bullrich mentioned this pull request Mar 6, 2024
Closed
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur bkontur approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joepetrowski @bkchr @xlc @kianenigma @bkontur @ggwpez @liamaharon