Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce chain-spec-generator and document Weight Generation process #127

Merged
merged 59 commits into from
Jan 17, 2024

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Dec 14, 2023

Closes #50

I am currently generating weights and will add them in a seperate PR when they are ready.

TODO

Why not use the polkadot-sdk generic chain-spec-builder?

The genesis state configs generated by this CLI are unusable for benchmarking, due to poor defaults. We need better defaults for our pallet genesis state before we can use this CLI. See also paritytech/polkadot-sdk#2713.

@liamaharon liamaharon changed the title Add chain-spec-generator and document Weight Generation process Introduce chain-spec-generator and document Weight Generation process Dec 14, 2023
@liamaharon
Copy link
Contributor Author

liamaharon commented Jan 15, 2024

@bkontur got back from break today, addressing comments and hope to merge asap.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from ggwpez January 17, 2024 08:18
@bkchr bkchr enabled auto-merge (squash) January 17, 2024 08:18
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bkchr bkchr merged commit 7515fc0 into polkadot-fellows:main Jan 17, 2024
16 checks passed
@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Mar 21, 2024

Why not use the polkadot-sdk generic chain-spec-builder?
The genesis state configs generated by this CLI are unusable for benchmarking, due to poor defaults. We need better defaults for our pallet genesis state before we can use this CLI. See also paritytech/polkadot-sdk#2713.

With work done in paritytech/polkadot-sdk#2714 the polkadot-sdk generic chain-spec-builder should be sufficient when it comes to initial genesis state.

There is still open question how to handle the rest of chain-spec (e.g. chain-name, id, tokenDecimals). Providing them in command line every time the tool is used will be inconvenient. As trivial/naive solution bunch of utility scripts could be provided. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for update benchmarks
9 participants