-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fellowship Salary Budget & Period #121
Fellowship Salary Budget & Period #121
Conversation
I am not familiar enough with the salary pallet to understand the tradeoffs so could someone explain the downside of having long |
|
@@ -251,7 +251,7 @@ impl pallet_salary::Config<FellowshipSalaryInstance> for Runtime { | |||
// 15 days to claim the salary payment. | |||
type PayoutPeriod = ConstU32<{ 15 * DAYS }>; | |||
// Total monthly salary budget. | |||
type Budget = ConstU128<{ 100_000 * USDT_UNITS }>; | |||
type Budget = ConstU128<{ 250_000 * USDT_UNITS }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we will want to make this number configurable, as obviously we need to adjust the budget every once a while. This will be a good candidate to integrate with parameters pallet, whatever it is the one in ORML, or polkadot-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we want very very quick win for this release:
parameter_types! {
pub storage Budget: u128 = 250_000 * USDT_UNITS`;
}
type Budget = Budget
and allow it for SafeCallFilter
here
// Allow to change dedicated storage items (called by governance-like)
match call {
RuntimeCall::System(frame_system::Call::set_storage { items })
if items.iter().all(|(k, _)| k.eq(&Budget::key()))) => return true,
_ => (),
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer just do the correct way. the storage parameters is not in metadata and hard to work with in frontend
Fellowship Salary Budget & Period
In alignment with the Fellowship Salary RFC, the projected total monthly budget stands at 240,833 USDt.
With this PR, I invite the Fellowship members to refine the following constant parameters:
Please be aware that the pallet does not have a visibility into the actual balance of the account holding the salary budget. If this account lacks sufficient assets, subsequent salary claims will encounter failures.