add test for pallet indices

system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs

@@ -26,7 +26,9 @@ use crate::{
 use cumulus_primitives_core::Junction::GeneralIndex;
 use frame_support::{
 	parameter_types,
-	traits::{EitherOf, EitherOfDiverse, MapSuccess, OriginTrait, TryWithMorphedArg},
+	traits::{
+		EitherOf, EitherOfDiverse, MapSuccess, OriginTrait, PalletInfoAccess, TryWithMorphedArg,
+	},
 	PalletId,
 };
 use frame_system::{EnsureRoot, EnsureRootWithSuccess};
@@ -261,7 +263,8 @@ parameter_types! {
 	pub const MaxBalance: Balance = Balance::max_value();
 	// The asset's interior location for the paying account. This is the Fellowship Treasury
 	// pallet instance (which sits at index 65).
-	pub FellowshipTreasuryInteriorLocation: InteriorMultiLocation = PalletInstance(65).into();
+	pub FellowshipTreasuryInteriorLocation: InteriorMultiLocation =
+		PalletInstance(<crate::FellowshipTreasury as PalletInfoAccess>::index() as u8).into();
 }
 
 /// [`PayOverXcm`] setup to pay the Fellowship Treasury.

system-parachains/collectives/collectives-polkadot/src/lib.rs

@@ -1014,3 +1014,21 @@ cumulus_pallet_parachain_system::register_validate_block! {
 	Runtime = Runtime,
 	BlockExecutor = cumulus_pallet_aura_ext::BlockExecutor::<Runtime, Executive>,
 }
+
+// TODO: Move these pallet index declarations to some `system-parachains/common` so that other
+// runtimes can import them without depending on the entire remote runtime.
+// Part of https://github.com/polkadot-fellows/runtimes/issues/59
+
+#[test]
+fn fellowship_salary_pallet_index() {
+	use frame_support::pallet_prelude::PalletInfoAccess;
+	// Remote accounts with funds depend on this pallet staying in the same index.
+	assert_eq!(<FellowshipSalary as PalletInfoAccess>::index() as u8, 64u8);
+}
+
+#[test]
+fn fellowship_treasury_pallet_index() {
+	use frame_support::pallet_prelude::PalletInfoAccess;
+	// Remote accounts with funds depend on this pallet staying in the same index.
+	assert_eq!(<FellowshipTreasury as PalletInfoAccess>::index() as u8, 65u8);
+}