Handle 0 exponent with fudged length correctly in ModExp #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
approved these changes
Jan 13, 2022
sorpaas
requested changes
Jan 13, 2022
sorpaas
reviewed
Jan 13, 2022
sorpaas
reviewed
Jan 13, 2022
… prevent underflow
Clean up test case Co-authored-by: Wei Tang <[email protected]>
|
I agree with your critiques, @sorpaas , and reverted the changes which made this look less like the original EIP. |
notlesh
commented
Jan 13, 2022
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Jan 13, 2022
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Jan 13, 2022
tgmichel
approved these changes
Jan 13, 2022
sorpaas
approved these changes
Jan 13, 2022
tgmichel
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Jan 14, 2022
…m#549) * Handle 0 exponent with fudged length correctly in ModExp * cargo fmt * Revert to following EIP-2565 strictly, subtract after adding terms to prevent underflow * Update frame/evm/precompile/modexp/src/lib.rs Clean up test case Co-authored-by: Wei Tang <[email protected]> * More revert * cargo fmt * Prefer expect to match Co-authored-by: Wei Tang <[email protected]> (cherry picked from commit 8a93fdc)
akru
added a commit
to AstarNetwork/Astar
that referenced
this pull request
Jan 15, 2022
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
…m#549) * Handle 0 exponent with fudged length correctly in ModExp * cargo fmt * Revert to following EIP-2565 strictly, subtract after adding terms to prevent underflow * Update frame/evm/precompile/modexp/src/lib.rs Clean up test case Co-authored-by: Wei Tang <[email protected]> * More revert * cargo fmt * Prefer expect to match Co-authored-by: Wei Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly handles an exponent of 0 in the ModExp precompile.