-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Marshal
and Unmarshal
methods to SM(S)T proof types
#21
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## kvstore #21 +/- ##
===========================================
- Coverage 84.89% 84.69% -0.20%
===========================================
Files 8 8
Lines 1092 1117 +25
===========================================
+ Hits 927 946 +19
- Misses 122 126 +4
- Partials 43 45 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Summary generated by Reviewpad on 06 Sep 23 15:52 UTC
This pull request introduces changes to the codebase related to serialization and deserialization of SparseMerkleProof and SparseCompactMerkleProof. The
Marshal
andUnmarshal
methods are added to both structures to convert them to bytes and vice versa. Additionally, some tests are added for these serialization methods to ensure their correctness.Issue
Fixes N/A
Type of change
Please mark the relevant option(s):
List of changes
Marshal
andUnmarshal
methods to both SM(S)T proof typesTesting
go test ...
go test ...
go test -v
Required Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist