revert transaction if buyer and seller is paying zero fees (#314)

pods-finance · Dec 14, 2021 · f97fbbc · f97fbbc
1 parent b18a21f
commit f97fbbc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/contracts/amm/OptionAMMPool.sol b/contracts/amm/OptionAMMPool.sol
@@ -929,6 +929,7 @@ contract OptionAMMPool is AMM, IOptionAMMPool, CappedPool, CombinedActionsGuard,
 
     function _onTrade(TradeDetails memory tradeDetails) internal override {
         uint256 newIV = abi.decode(tradeDetails.params, (uint256));
+        require(tradeDetails.feesTokenA > 0 && tradeDetails.feesTokenB > 0, "Pool: zero fees");
         priceProperties.currentIV = newIV;
 
         IERC20(tokenB()).safeTransfer(address(feePoolA), tradeDetails.feesTokenA);

diff --git a/test/amm/OptionAMMPool.test.js b/test/amm/OptionAMMPool.test.js
@@ -1170,6 +1170,24 @@ scenarios.forEach(scenario => {
 
         expect(bsPriceWithOracleIV).to.be.gte(bsPriceWithoutOracleIV)
       })
+      it('Should revert if caller is going to pay 0 fees due to a small trade', async () => {
+        const stableLiquidityToAdd = toBigNumber(60000).mul(toBigNumber(10).pow(scenario.strikeAssetDecimals))
+        const optionLiquidityToAdd = toBigNumber(100).mul(toBigNumber(10).pow(toBigNumber(scenario.underlyingAssetDecimals)))
+        const optionLiquidityToBuy = toBigNumber(1)
+
+        await addLiquidity(optionAMMPool, optionLiquidityToAdd, stableLiquidityToAdd, lp)
+
+        await mintOptions(option, optionLiquidityToBuy, buyer)
+        await mockStrikeAsset.connect(buyer).mint(stableLiquidityToAdd.mul(2))
+
+        await option.connect(buyer).approve(optionAMMPool.address, ethers.constants.MaxUint256)
+        await mockStrikeAsset.connect(buyer).approve(optionAMMPool.address, ethers.constants.MaxUint256)
+
+        const tradeDetails = await optionAMMPool.getOptionTradeDetailsExactAInput(optionLiquidityToBuy)
+
+        await expect(optionAMMPool.connect(buyer)
+          .tradeExactAInput(optionLiquidityToBuy, 0, buyerAddress, tradeDetails.newIV)).to.be.revertedWith('Pool: zero fees')
+      })
     })
 
     describe('Withdraw Amount > TotalBalance case', () => {