Pipelines fail with `SyntaxError: Unexpected token` #22

gaggle · 2021-10-12T11:47:17Z

Hi, we see occasional failed pipelines because, well, something goes wrong in pnpm/action-setup:

Running self-installer...
  [stdin]:1
  <HTML>
  ^
  SyntaxError: Unexpected token '<'
      at new Script (vm.js:84:7)
      at createScript (vm.js:258:10)
      at Object.runInThisContext (vm.js:306:10)
      at Object.<anonymous> ([stdin]-wrapper:9:26)
      at Module._compile (internal/modules/cjs/loader.js:959:30)
      at evalScript (internal/process/execution.js:80:25)
      at internal/main/eval_stdin.js:29:5
      at Socket.<anonymous> (internal/process/execution.js:192:5)
      at Socket.emit (events.js:215:7)
      at endReadableNT (_stream_readable.js:1184:12)
Error: Something does wrong, self-installer exits with code 1
Installation Completed!
Running pnpm recursive install --frozen-lockfile
Error: Command pnpm recursive install --frozen-lockfile (cwd: undefined) exits with status 127

I'm not sure if it's this line const response = await fetch('https://pnpm.js.org/pnpm.js') that might fail? If it somehow gets an HTML response? So if pnpm.js.org fails to return the pnpm.js script for a splitsecond, instead returning an HTML error page, then that could happen?

Will maintainers consider a retry mechanism to increase resilience? If the request is the cause of this error then an exponential backoff could work well, to try a couple times before giving up. WDYT?

The text was updated successfully, but these errors were encountered:

gaggle · 2021-10-12T12:01:15Z

Mm.. just got more failing pipelines, same as the error reported here. Maybe it's not random request/response errors if they occur so close together… could the endpoint be rate-limited? If response headers indicate when another request is allowed this action could delay until that time?

I assume the file itself cannot be cached locally to this action? It's not like it needs to re-download it every time if it was last fetched by another CI run a few minutes ago… but I'm not really sure what's possible in the GitHub Actions infrastructure.

gaggle · 2021-10-12T12:45:01Z

We run multiple jobs in parallel so now I suspect we're being ratelimited by the jobs starting in parallel that all download pnpm.js. Do you foresee a way to share the downloaded artifact for the whole CI job? I'm considering ways to download it once when the pipeline starts and somehow sharing the file-location with pnpm/action-setup.

I can help work on a PR, but looking to align w. maintainers before I go too crazy.

KSXGitHub · 2021-10-12T12:45:10Z

Are you using the latest version of pnpm/action-setup?

gaggle · 2021-10-12T13:03:23Z

Sorry I should have included that information, yes here's the pipeline snippet:

      - uses: pnpm/action-setup@v2
        with:
          version: ${{ env.pnpm-version }}
          run_install: |
            - recursive: true
              args: [--frozen-lockfile, --filter "${{ matrix.package }}..."]

That snippet sits inside a matrix that currently ramps up to 27 parallel jobs.

KSXGitHub · 2021-10-12T13:05:22Z

v2 is actually outdated. Use tag v2.0.1 instead. If you want to be up-to-date, just use dependabot.

gaggle · 2021-10-12T13:06:53Z

Yikes okay, thanks change.

KSXGitHub · 2021-10-12T13:10:07Z

We run multiple jobs in parallel so now I suspect we're being ratelimited by the jobs starting in parallel that all download pnpm.js

I tried downloading multiple pnpm.js concurrently (30 requests) but all of them were valid JavaScript files.

Anyway, I will leave this issue open for a month or two. If there is a problem, let me know.

gaggle · 2021-10-12T13:15:14Z

Thanks. If we see it again with the latest version we're discussing a fork to introduce additional debug information, and if the smoking gun points to the downlading of pnpm.js then we could introduce caching of it. But we'll wait and see too 👍

bkniffler · 2021-12-15T12:29:08Z

Just got the same issue with

- uses: pnpm/[email protected]
        with:
          version: 6.0.2
          run_install: true

hikariNTU · 2022-02-15T13:09:47Z

Same issue in Github matrix actions:

Run pnpm/[email protected]
  with:
    version: latest
    dest: ~/setup-pnpm
    run_install: null
  env:
    NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc
    NODE_AUTH_TOKEN: XXXXX-XXXXX-XXXXX-XXXXX
Running self-installer...
  [stdin]:1
  <HTML>
  ^
  
  SyntaxError: Unexpected token '<'
      at new Script (vm.js:84:7)
      at createScript (vm.js:258:10)
      at Object.runInThisContext (vm.js:306:10)
      at Object.<anonymous> ([stdin]-wrapper:9:26)
      at Module._compile (internal/modules/cjs/loader.js:959:30)
      at evalScript (internal/process/execution.js:80:25)
      at internal/main/eval_stdin.js:29:5
      at Socket.<anonymous> (internal/process/execution.js:192:5)
      at Socket.emit (events.js:215:7)
      at endReadableNT (_stream_readable.js:1184:12)
Error: Something went wrong, self-installer exits with code 1
Installation Completed!

We also set npmrc before installing pnpm:

Run actions/setup-node@v2
  with:
    node-version: 16.x
    registry-url: https://npm.pkg.github.com
    scope: ***
    always-auth: false
    check-latest: false
    token: ***
Found in cache @ /opt/hostedtoolcache/node/16.13.2/x64

But these setting should not be a problem.

And these actions only fail in an action

We will try to combine these actions together to make sure this is not rate limit problem later on.

razbensimon · 2022-02-20T08:59:35Z

Still happens to us on version 2.1.0. Any suggestions?
this is our usage:

- name: setup pnpm
        uses: pnpm/[email protected]
        with:
          version: 6.16.0

zkochan · 2022-02-20T19:42:42Z

maybe we should add some retries.

close #22

hikariNTU · 2022-02-21T04:00:13Z

@zkochan Can you elaborate more about this PR?
I don't know how does changing fetch's url and checking response's body can help to prevent server responding false js file?

DennisChungTW · 2022-02-21T04:06:56Z

I see, pnpm fetch utils seems dealing with falsy response with retry.

zkochan · 2022-02-21T09:58:18Z

how does changing fetch's url and checking response's body can help to prevent server responding false js file?

changing the URL is unrelated. It was just an old version, so I updated it.

The fix is in using @fetch/retry. When this issue happens, the HTTP response is a 500. @fetch/retry retries the request in this case.

zkochan · 2022-03-19T00:18:52Z

I have also configured cloudflare caching, so I don't think this will happen again

pnpm/get.pnpm.io@08d49fa

meteorlxy · 2022-05-25T09:29:31Z

Still ran into this issue today.

workflow log

dominikg · 2022-05-25T21:30:12Z

got a hit for this as well today: https://github.com/sveltejs/kit/runs/6599932579?check_suite_focus=true#step:4:14

given https://get.pnpm.io/install.sh exists, could this action embed (not download!) this shell script or an equivalent js implementation to download straight from npm registry instead?

that way it would no longer depend on availability of pnpm.io

zkochan · 2022-05-26T00:02:04Z

Can't we just commit that file to this repository?

zkochan · 2022-05-28T14:30:22Z

🚢 2.2.2

zkochan added a commit that referenced this issue Feb 20, 2022

fix: retry fetch of pnpm script

d8ea532

close #22

zkochan mentioned this issue Feb 20, 2022

fix: retry fetch of pnpm script #32

Merged

KSXGitHub closed this as completed in #32 Feb 21, 2022

KSXGitHub reopened this Feb 21, 2022

zkochan closed this as completed Mar 19, 2022

meteorlxy mentioned this issue May 26, 2022

chore(ci): remove pnpm version config vitejs/vite#8337

Merged

9 tasks

dominikg mentioned this issue May 27, 2022

MacOS 11: Something went wrong, self-installer exits with code 1 #44

Closed

zkochan mentioned this issue May 28, 2022

fix: do not download pnpm from get.pnpm.io #46

Merged

renovate bot mentioned this issue Jun 11, 2022

chore(deps): update all non-major dependencies stacksjs/table-elements#13

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipelines fail with `SyntaxError: Unexpected token` #22

Pipelines fail with `SyntaxError: Unexpected token` #22

gaggle commented Oct 12, 2021

gaggle commented Oct 12, 2021 •

edited

Loading

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

bkniffler commented Dec 15, 2021

hikariNTU commented Feb 15, 2022

razbensimon commented Feb 20, 2022

zkochan commented Feb 20, 2022

hikariNTU commented Feb 21, 2022

DennisChungTW commented Feb 21, 2022

zkochan commented Feb 21, 2022

zkochan commented Mar 19, 2022

meteorlxy commented May 25, 2022

dominikg commented May 25, 2022 •

edited

Loading

zkochan commented May 26, 2022

zkochan commented May 28, 2022

Pipelines fail with SyntaxError: Unexpected token #22

Pipelines fail with SyntaxError: Unexpected token #22

Comments

gaggle commented Oct 12, 2021

gaggle commented Oct 12, 2021 • edited Loading

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

KSXGitHub commented Oct 12, 2021

gaggle commented Oct 12, 2021

bkniffler commented Dec 15, 2021

hikariNTU commented Feb 15, 2022

razbensimon commented Feb 20, 2022

zkochan commented Feb 20, 2022

hikariNTU commented Feb 21, 2022

DennisChungTW commented Feb 21, 2022

zkochan commented Feb 21, 2022

zkochan commented Mar 19, 2022

meteorlxy commented May 25, 2022

dominikg commented May 25, 2022 • edited Loading

zkochan commented May 26, 2022

zkochan commented May 28, 2022

Pipelines fail with `SyntaxError: Unexpected token` #22

Pipelines fail with `SyntaxError: Unexpected token` #22

gaggle commented Oct 12, 2021 •

edited

Loading

dominikg commented May 25, 2022 •

edited

Loading