Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: run pnpm with old version node #18

Closed
chengcyber opened this issue Jul 27, 2021 · 2 comments · Fixed by #92
Closed

Feature request: run pnpm with old version node #18

chengcyber opened this issue Jul 27, 2021 · 2 comments · Fixed by #92

Comments

@chengcyber
Copy link
Member

What

This is a feature request to this action supports run pnpm@6 in node@10 environment.

Why

I use pnpm@6 in local dev, but my package wants to support node>=10, which break the rule of pnpm@6, engines.node >=12.

Detail

add a parameter (maybe named compiled_install),
If true, instead of install pnpm directly, run sth like curl -f https://get.pnpm.io/v6.js | node - add --global pnpm to setup a compiled pnpm binary as pnpm CLI

@KSXGitHub
Copy link
Collaborator

pnpm itself requires Node.js >= 12.17, as seen here:

Node.js v10 support is dropped. At least Node.js v12.17 is required for the package to work

So I think this issue is more suitable at pnpm/pnpm. But before that, consider workaround: Bundling pnpm@6 with node 12.17 into a self-contained binary.

@zkochan
Copy link
Member

zkochan commented Feb 8, 2022

We can do this easily by installing @pnpm/exe instead of pnpm. However, @pnpm/exe is only available since v6.17.1. So this will be a breaking change. But I think it is OK to do this breaking change since it will make pnpm work with older Node.js versions.

zkochan added a commit that referenced this issue Feb 9, 2022
This is a breaking change because the binary version of pnpm
is only available from v6.17.1

close #18
zkochan added a commit that referenced this issue Feb 9, 2022
This is a breaking change because the binary version of pnpm
is only available from v6.17.1

close #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants