Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder helper functions in fonts.py, clarify 'times' vs 'times new roman', and clarify 'usepackage{times}' vs 'usepackage{ptm}' #125

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

libbylbaker
Copy link
Contributor

This PR tries to make the font file more transparent.

  • The functions have been reordered so the helper functions, e.g. font families are at the bottom, and paper font functions are at the top
  • Font selection functions have been renamed to make clear which fonts they're defining
  • Neurips and ICML paper use times (instead of Times New Roman), so this has been corrected

tueplots/fonts.py Outdated Show resolved Hide resolved
@pnkraemer pnkraemer changed the title Reformat and correct fonts Reorder helper functions in fonts.py, clarify 'times' vs 'times new roman', and clarify 'usepackage{times}' vs 'usepackage{ptm}' Nov 20, 2023
@pnkraemer
Copy link
Owner

Thanks!

(We discussed most of these changes offline, so there is not much to review here.)

So technically, the new behaviour of iclr*() and neurips*() is not backwards-compatible because now they implement times instead of times new roman.

Not that many would notice a big difference between these two fonts, of course... :)

Copy link
Owner

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!

@pnkraemer pnkraemer merged commit 2ffe003 into pnkraemer:main Nov 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants