-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for maplibre maps #4706
Conversation
LiamConnors
commented
Aug 5, 2024
•
edited
Loading
edited
- Update docs
- Add new px functions
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟 Then you could duplicate your branch, rename all the docs files that has |
Here is a list of doc files that has
|
I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed |
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces. |
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161 |
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two. |
We should keep some mapbox examples, but like in |
There is also |
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to. |
Co-authored-by: Emily KL <[email protected]>
Co-authored-by: Liam Connors <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
This reverts commit ba9c413.
Add new `map` options to `px` and update plotly.js/master at 056799dfc705a4533935ae3169cc94d35bc44830