Use URLs directly for layout images #7199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data uri is necessary for export only, which should always use staticPlot - so if we're not in staticPlot mode, skip this conversion. Hoping this will improve the experience for plots that make heavy & dynamic use of layout images, by keeping the plotting process synchronous - which I'm calling a bug because we've seen the display become glitchy during pan/zoom in these cases.
I'll have a couple of tests to adapt as well as a changelog entry to add... but first I'm going to use the circleci build for testing in our application.